src/ia32/code-stubs-ia32.cc - Issue 11662009: Fix typo in the CheckSSE2OperandIsInt32: use bitwise not instead of integer negation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/code-stubs-ia32.cc

Issue 11662009: Fix typo in the CheckSSE2OperandIsInt32: use bitwise not instead of integer negation. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/code-stubs-ia32.cc

diff --git a/src/ia32/code-stubs-ia32.cc b/src/ia32/code-stubs-ia32.cc

index 783b97d8ad546fc72565b2d8c6967220bb049fa8..92d24ba6cc88106b409a907762a154fb6e32531e 100644

--- a/src/ia32/code-stubs-ia32.cc

+++ b/src/ia32/code-stubs-ia32.cc

@@ -2872,7 +2872,8 @@ void FloatingPointHelper::CheckSSE2OperandIsInt32(MacroAssembler* masm,

__ cvtsi2sd(xmm_scratch, scratch);

__ pcmpeqd(xmm_scratch, operand);

__ movmskps(scratch, xmm_scratch);

- __ neg(scratch);

+ // Two least significant bits should be both set.

+ __ not_(scratch);

__ test(scratch, Immediate(3));

__ j(not_zero, non_int32);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »