Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11662004: Refactor NetworkLibraryImplBase::LoadOncNetworks. (Closed)

Created:
8 years ago by pneubeck (no reviews)
Modified:
7 years, 11 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Refactor NetworkLibraryImplBase::LoadOncNetworks. This prepares the replacement of OncNetworkParser by the new ONC translator. BUG=162040 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176311

Patch Set 1 : Initial patch. #

Total comments: 4

Patch Set 2 : Fixed nits. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -34 lines) Patch
M chrome/browser/chromeos/cros/network_library_impl_base.cc View 1 2 4 chunks +21 lines, -34 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
pneubeck (no reviews)
A refactoring of the LoadOncNetworks function which makes the following removal of OncNetworkParser clearer.
8 years ago (2012-12-21 14:56:43 UTC) #1
Greg Spencer (Chromium)
lgtm https://codereview.chromium.org/11662004/diff/1002/chrome/browser/chromeos/cros/network_library_impl_base.cc File chrome/browser/chromeos/cros/network_library_impl_base.cc (right): https://codereview.chromium.org/11662004/diff/1002/chrome/browser/chromeos/cros/network_library_impl_base.cc#newcode1158 chrome/browser/chromeos/cros/network_library_impl_base.cc:1158: // Don't configure a network that is supposed ...
8 years ago (2012-12-21 17:52:45 UTC) #2
stevenjb
lgtm owner lgtm
8 years ago (2012-12-21 18:27:03 UTC) #3
pneubeck (no reviews)
Addressed the comments. https://codereview.chromium.org/11662004/diff/1002/chrome/browser/chromeos/cros/network_library_impl_base.cc File chrome/browser/chromeos/cros/network_library_impl_base.cc (right): https://codereview.chromium.org/11662004/diff/1002/chrome/browser/chromeos/cros/network_library_impl_base.cc#newcode1158 chrome/browser/chromeos/cros/network_library_impl_base.cc:1158: // Don't configure a network that ...
7 years, 11 months ago (2013-01-08 13:40:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/11662004/10001
7 years, 11 months ago (2013-01-10 20:22:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/11662004/10001
7 years, 11 months ago (2013-01-11 10:22:43 UTC) #6
commit-bot: I haz the power
7 years, 11 months ago (2013-01-11 11:17:40 UTC) #7
Message was sent while issue was closed. 
Change committed as 176311

Powered by Google App Engine
This is Rietveld 408576698