cc: Put context-loss tests in layer_tree_host_unittest_context.cc

cc/tiled_layer.h

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_TILED_LAYER_H_
 #define CC_TILED_LAYER_H_
 
 #include "cc/cc_export.h"
 #include "cc/contents_scaling_layer.h"
 #include "cc/layer_tiling_data.h"
@@ skipping 47 matching lines @@
     void resetUpdateState();
 
     // After preparing an update, returns true if more painting is needed.
     bool needsIdlePaint();
     gfx::Rect idlePaintRect();
 
     bool skipsDraw() const { return m_skipsDraw; }
 
     // Virtual for testing
     virtual PrioritizedResourceManager* resourceManager() const;
+    const LayerTilingData* tilerForTesting() const { return m_tiler.get(); }
+    const PrioritizedResource* resourceAtForTesting(int, int) const;

[enne (OOO), 2013/01/02 20:30:39]

I wish there were some better way to do all of these.  Maybe
s/private/protected/ below would let FakeContentLayer expose these functions,
rather than putting them on TiledLayer?

[danakj, 2013/01/02 20:45:00]

I kinda like them here because they are closer to the real code, so you can more
easily see the relationship to the real code, and maybe they have a better
chance of staying correct over time. With the ForTesting, it prevents anything
else from using it.

But, I'm okay with moving them entirely to the FakeContentLayer too.

[danakj, 2013/01/02 20:46:20]

I will also say, I like this a bit better than making m_tiler protected, because
that exposes it for non-testing code. Whereas this does not.

 
 private:
     virtual scoped_ptr<LayerImpl> createLayerImpl(LayerTreeImpl* treeImpl) OVERRIDE;
 
     void createTilerIfNeeded();
     void setTilingOption(TilingOption);
 
     bool tileOnlyNeedsPartialUpdate(UpdatableTile*);
     bool tileNeedsBufferedUpdate(UpdatableTile*);
 
@@ skipping 19 matching lines @@
     gfx::Rect m_predictedVisibleRect;
     gfx::Rect m_previousVisibleRect;
     gfx::Size m_previousContentBounds;
 
     TilingOption m_tilingOption;
     scoped_ptr<LayerTilingData> m_tiler;
 };
 
 }
 #endif  // CC_TILED_LAYER_H_