Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 1166163003: Oilpan: revert back to a prefinalizer for LocalDOMWindow. (Closed)

Created:
5 years, 6 months ago by sof
Modified:
5 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: revert back to a prefinalizer for LocalDOMWindow. As LocalDOMWindow may end up being accessed by eagerly finalized objects from their destructors, fall back to using a prefinalizer for it so as to avoid illegal, cross-object access amongst eagerly finalized objects. R=haraken BUG=491488 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196890

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -12 lines) Patch
M Source/core/frame/LocalDOMWindow.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 3 chunks +21 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
please take a look. Just wanted to put it on the table, at least.
5 years, 6 months ago (2015-06-10 14:23:48 UTC) #2
haraken
LGTM
5 years, 6 months ago (2015-06-10 15:22:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166163003/1
5 years, 6 months ago (2015-06-10 18:36:56 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 18:40:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196890

Powered by Google App Engine
This is Rietveld 408576698