Issue 1166153002: Add a basic popup menu implementation to stocks2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1166153002: Add a basic popup menu implementation to stocks2 (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:
Hixie

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Add a basic popup menu implementation to stocks2 The popup menu is displayed in the wrong location with the wrong width, but it does draw. I've also removed the checkbox because the flex container was causing me trouble. I'll add it back in a later CL. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/81632872297cc3776f31478a24e4195dfb5843cd

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+69 lines, -79 lines)			Patch
M	sky/examples/stocks2/lib/stock_app.dart	View	4 chunks	+20 lines, -20 lines	0 comments	Download
M	sky/examples/stocks2/lib/stock_menu.dart	View	2 chunks	+12 lines, -16 lines	0 comments	Download
M	sky/sdk/lib/framework/components2/checkbox.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/sdk/lib/framework/components2/modal_overlay.dart	View	2 chunks	+7 lines, -9 lines	0 comments	Download
M	sky/sdk/lib/framework/components2/popup_menu.dart	View	4 chunks	+26 lines, -30 lines	0 comments	Download
M	sky/sdk/lib/framework/components2/popup_menu_item.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/sdk/lib/framework/fn2.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 6 months ago (2015-06-08 19:52:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
81632872297cc3776f31478a24e4195dfb5843cd (presubmit successful).