Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: remoting/PRESUBMIT.py

Issue 1166123004: Add simple presubmit check to remoting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Include tracking bug # for TODO. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/PRESUBMIT.py
diff --git a/remoting/PRESUBMIT.py b/remoting/PRESUBMIT.py
new file mode 100644
index 0000000000000000000000000000000000000000..ea8d1c935dcb6473f081b995e23fb53150854ae3
--- /dev/null
+++ b/remoting/PRESUBMIT.py
@@ -0,0 +1,26 @@
+# Copyright 2015 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Presubmit script for remoting.
+
+See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
+for more details about the presubmit API built into depot_tools.
+"""
+
+BROWSER_TEST_INSTRUCTIONS_LINK = (
+ "https://wiki.corp.google.com/twiki/bin/view/Main/ChromotingWaterfall#Running_on_a_Swarming_bot.")
Sergey Ulanov 2015/06/09 23:19:05 I don't think you need the . at the end.
Sergey Ulanov 2015/06/09 23:19:05 Instructions on that page look long and confusing.
+
+
+def CheckChangeOnUpload(input_api, output_api):
+ print "*******IMPORTANT NOTE*******"
+ print "Before committing, please run Remoting browser_tests."
+ print "Instructions: %s" % BROWSER_TEST_INSTRUCTIONS_LINK
+ print "Make sure all tests pass."
+ return []
+
+
+def CheckChangeOnCommit(input_api, output_api):
+ """TODO(anandc): Run browser-tests on the Chromoting waterfall as part of
+ committing a CL. See http://crbug/498026"""
+ return []
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698