Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Unified Diff: Source/core/layout/TracedLayoutObject.cpp

Issue 1166123002: Use isolatedCopies for TracedLayoutObject strings (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/TracedLayoutObject.cpp
diff --git a/Source/core/layout/TracedLayoutObject.cpp b/Source/core/layout/TracedLayoutObject.cpp
index 5ce63024b8811f92ae6eee4b655cc0d70ffaa1a8..586e234b195e25efe1ab10adc3a99fb0ff12b761 100644
--- a/Source/core/layout/TracedLayoutObject.cpp
+++ b/Source/core/layout/TracedLayoutObject.cpp
@@ -37,18 +37,19 @@ TracedLayoutObject::TracedLayoutObject(const LayoutObject& object)
, m_childNeeds(object.normalChildNeedsLayout())
, m_posChildNeeds(object.posChildNeedsLayout())
, m_isTableCell(object.isTableCell())
- , m_name(object.name())
+ , m_name(String(object.name()).isolatedCopy())
, m_absRect(object.absoluteBoundingBoxRect())
{
if (Node* node = object.node()) {
- m_tag = node->nodeName();
+ m_tag = String(node->nodeName()).isolatedCopy();
if (node->isElementNode()) {
Element& element = toElement(*node);
if (element.hasID())
- m_id = element.getIdAttribute();
+ m_id = String(element.getIdAttribute()).isolatedCopy();
if (element.hasClass()) {
for (size_t i = 0; i < element.classNames().size(); ++i) {
- m_classNames.append(element.classNames()[i]);
+ m_classNames.append(
+ String(element.classNames()[i]).isolatedCopy());
}
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698