Chromium Code Reviews
|
|
|
Created:
4 years, 10 months ago by fmeawad Modified:
4 years, 10 months ago CC:
benjhayden, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1 Base URL:
https://chromium.googlesource.com/chromium/blink.git@master Target Ref:
refs/heads/master Project:
blink Visibility:
Public. |
DescriptionUse isolatedCopies for TracedLayoutObject strings
BUG=497832
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196818
Patch Set 1 #
Messages
Total messages: 18 (7 generated)
fmeawad@chromium.org changed reviewers: + jchaffraix@chromium.org
PTAL.
The CQ bit was checked by fmeawad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166123002/1
On 2015/06/08 at 19:14:27, commit-bot wrote: > Dry run: CQ is trying da patch. Follow status at > https://chromium-cq-status.appspot.com/patch-status/1166123002/1 How does this object end up on a different thread before it's converted?
On 2015/06/08 19:32:22, dsinclair wrote: > On 2015/06/08 at 19:14:27, commit-bot wrote: > > Dry run: CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/patch-status/1166123002/1 > > > How does this object end up on a different thread before it's converted? I am capturing the actual scenario. But the crash started happening when collecting traces using background_tracing_manager (Which runs on the content::BrowserThread::UI thread).
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2015/06/08 21:26:52, commit-bot: I haz the power wrote: > Dry run: This issue passed the CQ dry run. According to this CL https://codereview.chromium.org/1035783002/, ConvertTraceEventsToTraceFormat can happen on a different thread. I have added more details to the bug.
dsinclair@chromium.org changed reviewers: + dsinclair@chromium.org
lgtm
The CQ bit was checked by jchaffraix@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166123002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/65929)
The CQ bit was checked by fmeawad@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166123002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=196818 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
