Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 1166043003: Fix reflection mask bounds to include visual overflow (Closed)

Created:
4 years, 10 months ago by pdr.
Modified:
4 years, 10 months ago
Reviewers:
chrishtr, Xianzhu
CC:
blink-reviews, blink-reviews-paint_chromium.org, dshwang, slimming-paint-reviews_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Fix reflection mask bounds to include visual overflow When ReplicaPainter::paint painted masks it would use LayoutBox::size which does not account for visual overflow. This patch switches to using LayoutBox::visualOverflowRect, also fixing cases where zoom != 1. TEST=fast/reflections/reflection-masks-outset.html with slimming paint and SlimmingPaintStrictCullRectClipping enabled. BUG=496316 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196647

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M Source/core/paint/ReplicaPainter.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
pdr.
4 years, 10 months ago (2015-06-07 15:38:28 UTC) #2
Xianzhu
lgtm
4 years, 10 months ago (2015-06-07 17:29:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166043003/1
4 years, 10 months ago (2015-06-07 23:11:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/65580)
4 years, 10 months ago (2015-06-08 02:35:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166043003/1
4 years, 10 months ago (2015-06-08 03:00:03 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2015-06-08 03:59:06 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196647

Powered by Google App Engine
This is Rietveld 408576698