Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart

Issue 11660029: Fix noSuchMethod internal name for getter/setter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/language_dart2js.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart b/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
index fa15b14287c333419e9342dccf10014eef373db5..db8a2d35fb7f9bf277af9781b888ea04629d563e 100644
--- a/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
+++ b/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
@@ -879,17 +879,17 @@ $lazyInitializerLogic
}
void generateGetter(Element member, String fieldName, String accessorName,
- CodeBuffer buffer) {
+ CodeBuffer buffer) {
String getterName = namer.getterNameFromAccessorName(accessorName);
- buffer.add("$getterName: function() { return this.$fieldName; }");
- }
-
+ buffer.add("$getterName: function() { return this.$fieldName; }");
+ }
+
void generateSetter(Element member, String fieldName, String accessorName,
- CodeBuffer buffer) {
+ CodeBuffer buffer) {
String setterName = namer.setterNameFromAccessorName(accessorName);
- buffer.add("$setterName: function(v) { this.$fieldName = v; }");
- }
-
+ buffer.add("$setterName: function(v) { this.$fieldName = v; }");
+ }
+
bool canGenerateCheckedSetter(Element member) {
DartType type = member.computeType(compiler);
if (type.element.isTypeVariable()
@@ -1739,8 +1739,7 @@ $lazyInitializerLogic
selector.getOrderedNamedArguments().map((SourceString name) =>
new js.LiteralString('"${name.slowToString()}"'));
- String internalName = namer.instanceMethodInvocationName(
- selector.library, new SourceString(methodName), selector);
+ String internalName = namer.invocationMirrorInternalName(selector);
String createInvocationMirror = namer.getName(
compiler.createInvocationMirrorElement);
« no previous file with comments | « no previous file | tests/language/language_dart2js.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698