Move the parsing of "chrome_url_overrides" out of Extension.

chrome/common/extensions/manifest_url_handler.cc

Index: chrome/common/extensions/manifest_url_handler.cc
diff --git a/chrome/common/extensions/manifest_url_handler.cc b/chrome/common/extensions/manifest_url_handler.cc
index 8dcbe1e006591549558d22eeee3795d5c07235bb..02558024138b0c9f632489b3c05001ac05a48bc8 100644
--- a/chrome/common/extensions/manifest_url_handler.cc
+++ b/chrome/common/extensions/manifest_url_handler.cc
@@ -4,10 +4,15 @@
 
 #include "chrome/common/extensions/manifest_url_handler.h"
 
+#include "base/lazy_instance.h"
 #include "base/memory/scoped_ptr.h"
+#include "base/string_util.h"
+#include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
+#include "chrome/common/chrome_constants.h"
 #include "chrome/common/extensions/extension_manifest_constants.h"
+#include "chrome/common/url_constants.h"
 #include "extensions/common/error_utils.h"
 
 namespace keys = extension_manifest_keys;
@@ -17,6 +22,8 @@ namespace extensions {
 
 namespace {
 
+const char kOverrideExtentUrlPatternFormat[] = "chrome://%s/*";
+
 const GURL& GetManifestURL(const Extension* extension,
                            const std::string& key) {
   ManifestURL* manifest_url =
@@ -41,6 +48,25 @@ const GURL ManifestURL::GetHomepageURL(const Extension* extension) {
       GURL::EmptyGURL();
 }
 
+URLOverrides::URLOverrides() {
+}
+
+URLOverrides::~URLOverrides() {
+}
+
+static base::LazyInstance<URLOverrides::URLOverrideMap> g_empty_url_overrides =
+    LAZY_INSTANCE_INITIALIZER;
+
+// static
+const URLOverrides::URLOverrideMap&
+    URLOverrides::GetChromeURLOverrides(const Extension* extension) {
+  URLOverrides* url_overrides = static_cast<URLOverrides*>(
+      extension->GetManifestData(keys::kChromeURLOverrides));
+  return url_overrides ?
+         url_overrides->chrome_url_overrides_ :
+         g_empty_url_overrides.Get();
+}
+
 DevToolsPageHandler::DevToolsPageHandler() {
 }
 
@@ -89,4 +115,70 @@ bool HomepageURLHandler::Parse(const base::Value* value,
   return true;
 }
 
+URLOverridesHandler::URLOverridesHandler() {
+}
+
+URLOverridesHandler::~URLOverridesHandler() {
+}
+
+bool URLOverridesHandler::Parse(const base::Value* value,
+                           Extension* extension,
+                           string16* error) {
+  const DictionaryValue* overrides = NULL;
+  if (!value->GetAsDictionary(&overrides)) {
+    *error = ASCIIToUTF16(errors::kInvalidChromeURLOverrides);
+    return false;
+  }
+  scoped_ptr<URLOverrides> url_overrides(new URLOverrides);
+  // Validate that the overrides are all strings
+  for (DictionaryValue::key_iterator iter = overrides->begin_keys();
+       iter != overrides->end_keys(); ++iter) {
+    std::string page = *iter;
+    std::string val;
+    // Restrict override pages to a list of supported URLs.
+    bool is_override = (page != chrome::kChromeUINewTabHost &&
+                        page != chrome::kChromeUIBookmarksHost &&
+                        page != chrome::kChromeUIHistoryHost);
+#if defined(OS_CHROMEOS)
+    is_override = (is_override &&
+                   page != chrome::kChromeUIActivationMessageHost);
+#endif
+#if defined(FILE_MANAGER_EXTENSION)
+    is_override = (is_override &&
+                   !(extension->location() == Extension::COMPONENT &&
+                     page == chrome::kChromeUIFileManagerHost));
+#endif
+
+    if (is_override || !overrides->GetStringWithoutPathExpansion(*iter, &val)) {
+      *error = ASCIIToUTF16(errors::kInvalidChromeURLOverrides);
+      return false;
+    }
+    // Replace the entry with a fully qualified chrome-extension:// URL.
+    url_overrides->chrome_url_overrides_[page] = extension->GetResourceURL(val);
+
+    // For component extensions, add override URL to extent patterns.
+    if (extension->is_legacy_packaged_app() &&
+        extension->location() == Extension::COMPONENT) {
+      URLPattern pattern(URLPattern::SCHEME_CHROMEUI);
+      std::string url = base::StringPrintf(kOverrideExtentUrlPatternFormat,
+                                           page.c_str());
+      if (pattern.Parse(url) != URLPattern::PARSE_SUCCESS) {
+        *error = ErrorUtils::FormatErrorMessageUTF16(
+            errors::kInvalidURLPatternError, url);
+        return false;
+      }
+      extension->AddWebExtentPattern(pattern);
+    }
+  }
+
+  // An extension may override at most one page.
+  if (overrides->size() > 1) {
+    *error = ASCIIToUTF16(errors::kMultipleOverrides);
+    return false;
+  }
+  extension->SetManifestData(keys::kChromeURLOverrides,
+                             url_overrides.release());
+  return true;
+}
+
 }  // namespace extensions