Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4733)

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 11660016: Move the parsing of "chrome_url_overrides" out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index 6ba4c14a8c885fd7b0b9f331a3c50ab8a5d408a3..16fd41c0dd9528b5fc94b9911b601053afea0c50 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -52,7 +52,6 @@
#include "chrome/browser/extensions/extension_special_storage_policy.h"
#include "chrome/browser/extensions/extension_sync_data.h"
#include "chrome/browser/extensions/extension_system.h"
-#include "chrome/browser/extensions/extension_web_ui.h"
#include "chrome/browser/extensions/external_install_ui.h"
#include "chrome/browser/extensions/external_provider_impl.h"
#include "chrome/browser/extensions/external_provider_interface.h"
@@ -81,6 +80,7 @@
#include "chrome/common/chrome_paths.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/chrome_version_info.h"
+#include "chrome/common/extensions/api/url_overrides/url_overrides_handler.h"
Joe Thomas 2012/12/21 20:17:05 I will remove this.
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_file_util.h"
#include "chrome/common/extensions/extension_manifest_constants.h"
@@ -1079,9 +1079,6 @@ void ExtensionService::NotifyExtensionLoaded(const Extension* extension) {
UpdateActiveExtensionsInCrashReporter();
- ExtensionWebUI::RegisterChromeURLOverrides(
- profile_, extension->GetChromeURLOverrides());
-
// If the extension has permission to load chrome://favicon/ resources we need
// to make sure that the FaviconSource is registered with the
// ChromeURLDataManager.
@@ -1171,9 +1168,6 @@ void ExtensionService::NotifyExtensionUnloaded(
profile_->GetExtensionSpecialStoragePolicy()->
RevokeRightsForExtension(extension);
- ExtensionWebUI::UnregisterChromeURLOverrides(
- profile_, extension->GetChromeURLOverrides());
-
#if defined(OS_CHROMEOS)
// Revoke external file access to third party extensions.
fileapi::FileSystemContext* filesystem_context =
« no previous file with comments | « chrome/browser/extensions/extension_override_apitest.cc ('k') | chrome/browser/extensions/extension_web_ui.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698