Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1610)

Unified Diff: chrome/browser/extensions/extension_web_ui.cc

Issue 11660016: Move the parsing of "chrome_url_overrides" out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_web_ui.cc
diff --git a/chrome/browser/extensions/extension_web_ui.cc b/chrome/browser/extensions/extension_web_ui.cc
index 144787007af5c341d57f10a43f3c92a9803b24c9..c5cb1236c0513743767c4fab260fc442ca6d2a62 100644
--- a/chrome/browser/extensions/extension_web_ui.cc
+++ b/chrome/browser/extensions/extension_web_ui.cc
@@ -21,6 +21,7 @@
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/tab_contents/tab_contents_iterator.h"
#include "chrome/common/chrome_switches.h"
+#include "chrome/common/extensions/api/url_overrides/url_overrides_handler.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_constants.h"
#include "chrome/common/extensions/extension_icon_set.h"
@@ -38,6 +39,7 @@
using content::WebContents;
using extensions::Extension;
+using extensions::URLOverridesInfo;
namespace {
@@ -303,7 +305,7 @@ bool ExtensionWebUI::HandleChromeURLOverrideReverse(
// static
void ExtensionWebUI::RegisterChromeURLOverrides(
- Profile* profile, const Extension::URLOverrideMap& overrides) {
+ Profile* profile, const URLOverridesInfo::URLOverrideMap& overrides) {
if (overrides.empty())
return;
@@ -313,7 +315,7 @@ void ExtensionWebUI::RegisterChromeURLOverrides(
// For each override provided by the extension, add it to the front of
// the override list if it's not already in the list.
- Extension::URLOverrideMap::const_iterator iter = overrides.begin();
+ URLOverridesInfo::URLOverrideMap::const_iterator iter = overrides.begin();
for (; iter != overrides.end(); ++iter) {
const std::string& key = iter->first;
ListValue* page_overrides;
@@ -381,13 +383,13 @@ void ExtensionWebUI::UnregisterChromeURLOverride(const std::string& page,
// static
void ExtensionWebUI::UnregisterChromeURLOverrides(
- Profile* profile, const Extension::URLOverrideMap& overrides) {
+ Profile* profile, const URLOverridesInfo::URLOverrideMap& overrides) {
if (overrides.empty())
return;
PrefService* prefs = profile->GetPrefs();
DictionaryPrefUpdate update(prefs, kExtensionURLOverrides);
DictionaryValue* all_overrides = update.Get();
- Extension::URLOverrideMap::const_iterator iter = overrides.begin();
+ URLOverridesInfo::URLOverrideMap::const_iterator iter = overrides.begin();
for (; iter != overrides.end(); ++iter) {
const std::string& page = iter->first;
ListValue* page_overrides;

Powered by Google App Engine
This is Rietveld 408576698