Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: chrome/common/extensions/api/url_overrides/url_overrides_manifests_unittest.cc

Issue 11660016: Move the parsing of "chrome_url_overrides" out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/api/url_overrides/url_overrides_handler.h"
6 #include "chrome/common/extensions/extension_manifest_constants.h"
7 #include "chrome/common/extensions/manifest_handler.h"
5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 8 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
6
7 #include "chrome/common/extensions/extension_manifest_constants.h"
8 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
9 10
11 namespace keys = extension_manifest_keys;
10 namespace errors = extension_manifest_errors; 12 namespace errors = extension_manifest_errors;
11 13
12 TEST_F(ExtensionManifestTest, Override) { 14 using extensions::Extension;
15
16 namespace {
17
18 class URLOverridesManifestTest : public ExtensionManifestTest {
19 virtual void SetUp() OVERRIDE {
20 ExtensionManifestTest::SetUp();
21 extensions::ManifestHandler::Register(keys::kChromeURLOverrides,
22 new extensions::URLOverridesHandler);
23 }
24 };
25
26 TEST_F(URLOverridesManifestTest, Override) {
13 Testcase testcases[] = { 27 Testcase testcases[] = {
14 Testcase("override_newtab_and_history.json", errors::kMultipleOverrides), 28 Testcase("override_newtab_and_history.json", errors::kMultipleOverrides),
15 Testcase("override_invalid_page.json", errors::kInvalidChromeURLOverrides) 29 Testcase("override_invalid_page.json", errors::kInvalidChromeURLOverrides)
16 }; 30 };
17 RunTestcases(testcases, arraysize(testcases), 31 RunTestcases(testcases, arraysize(testcases),
18 EXPECT_TYPE_ERROR); 32 EXPECT_TYPE_ERROR);
19 33
20 scoped_refptr<extensions::Extension> extension; 34 scoped_refptr<extensions::Extension> extension;
21 35
22 extension = LoadAndExpectSuccess("override_new_tab.json"); 36 extension = LoadAndExpectSuccess("override_new_tab.json");
23 EXPECT_EQ(extension->url().spec() + "newtab.html", 37 EXPECT_EQ(extension->url().spec() + "newtab.html",
24 extension->GetChromeURLOverrides().find("newtab")->second.spec()); 38 extensions::URLOverridesInfo::GetChromeURLOverrides(extension).
39 find("newtab")->second.spec());
25 40
26 extension = LoadAndExpectSuccess("override_history.json"); 41 extension = LoadAndExpectSuccess("override_history.json");
27 EXPECT_EQ(extension->url().spec() + "history.html", 42 EXPECT_EQ(extension->url().spec() + "history.html",
28 extension->GetChromeURLOverrides().find("history")->second.spec()); 43 extensions::URLOverridesInfo::GetChromeURLOverrides(extension).
44 find("history")->second.spec());
29 } 45 }
46
47 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698