Pass ASan .saves file to strip when real .dSYM files are built.

Pass ASan .saves file to strip when real .dSYM files are built.

BUG=128544, 166857
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174572

[Alexander Potapenko, 2012-12-21 13:16:00]

Mark, WDYT?
When we're building with asan=1 and mac_want_real_dsym=1 (which is to be implied
by asan=1 soon), Xcode runs `strip` to strip the binaries after dsymutil. In
this case asan.saves isn't used, so ASan interface symbols (like __asan_init)
that are required by the shared libraries, are being stripped away.

[Mark Mentovai, 2012-12-21 14:01:31]

The strip-save file was intended to be used for executables, but this applies to
other target types. Do you need it for non-executables, and if so, why?

(I beg forgiveness if you already explained this, these asan linker changes
aren’t coming frequently enough to retain all of the context each time.)

[Alexander Potapenko, 2012-12-21 14:05:28]

You're right, it's used only for executables by strip_from_xcode.
I'll fix that right away

[Alexander Potapenko, 2012-12-21 14:09:45]

On 2012/12/21 14:05:28, Alexander Potapenko wrote:
> You're right, it's used only for executables by strip_from_xcode.
> I'll fix that right away

Oh wait, the condition above already restricts _type to {shared_library,
loadable_module, executable}, so my change actually applies to executables only.
But let me rephrase that in the CL

[Alexander Potapenko, 2012-12-21 14:27:11]

Done

[Mark Mentovai, 2012-12-21 14:33:00]

That’s better. LGTM.

[Alexander Potapenko, 2012-12-21 15:10:38]

On 2012/12/21 14:33:00, Mark Mentovai wrote:
> That’s better. LGTM.

Updated - asan==1 should be in conditions, not in target_conditions.

[Nico, 2012-12-21 15:31:03]

On 2012/12/21 15:10:38, Alexander Potapenko wrote:
> On 2012/12/21 14:33:00, Mark Mentovai wrote:
> > That’s better. LGTM.
> 
> Updated - asan==1 should be in conditions, not in target_conditions.

Can you add either the asan dsym bug or the line tables bug or both to the BUG=
line?