Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: sky/examples/stocks2/lib/stock_app.dart

Issue 1165983002: Stub out InkWell and implement Sky’s fn2 menu item (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/examples/stocks2/lib/stock_app.dart
diff --git a/sky/examples/stocks2/lib/stock_app.dart b/sky/examples/stocks2/lib/stock_app.dart
index de1fa38f5088c2404e63380d2f8f9ef3b395a048..1150e03f44646fae1b97281aca24145e3f22f2e3 100644
--- a/sky/examples/stocks2/lib/stock_app.dart
+++ b/sky/examples/stocks2/lib/stock_app.dart
@@ -10,7 +10,7 @@ import 'package:sky/framework/components2/drawer.dart';
import 'package:sky/framework/components2/icon_button.dart';
// import 'package:sky/framework/components2/input.dart';
// import 'package:sky/framework/components2/menu_divider.dart';
-// import 'package:sky/framework/components2/menu_item.dart';
+import 'package:sky/framework/components2/menu_item.dart';
// import 'package:sky/framework/components2/modal_overlay.dart';
// import 'package:sky/framework/components2/popup_menu.dart';
// import 'package:sky/framework/components2/radio.dart';
@@ -118,45 +118,44 @@ class StocksApp extends App {
Drawer buildDrawer() {
return new Drawer(
controller: _drawerController,
- level: 3
- // ,
- // children: [
- // new DrawerHeader(children: [new Text('Stocks')]),
- // new MenuItem(
- // key: 'Stock list',
- // icon: 'action/assessment',
- // children: [new Text('Stock List')]),
- // new MenuItem(
- // key: 'Account Balance',
- // icon: 'action/account_balance',
- // children: [new Text('Account Balance')]),
- // new MenuDivider(key: 'div1'),
- // new MenuItem(
- // key: 'Optimistic Menu Item',
- // icon: 'action/thumb_up',
- // onGestureTap: (event) => _handleStockModeChange(StockMode.Optimistic),
- // children: [
- // new ParentDataNode(new Text('Optimistic'), _flex1),
- // new Radio(key: 'optimistic-radio', value: StockMode.Optimistic, groupValue: _stockMode, onChanged: _handleStockModeChange)
- // ]),
- // new MenuItem(
- // key: 'Pessimistic Menu Item',
- // icon: 'action/thumb_down',
- // onGestureTap: (event) => _handleStockModeChange(StockMode.Pessimistic),
- // children: [
- // new ParentDataNode(new Text('Pessimistic'), _flex1),
- // new Radio(key: 'pessimistic-radio', value: StockMode.Pessimistic, groupValue: _stockMode, onChanged: _handleStockModeChange)
- // ]),
- // new MenuDivider(key: 'div2'),
- // new MenuItem(
- // key: 'Settings',
- // icon: 'action/settings',
- // children: [new Text('Settings')]),
- // new MenuItem(
- // key: 'Help & Feedback',
- // icon: 'action/help',
- // children: [new Text('Help & Feedback')])
- // ]
+ level: 3,
+ children: [
+ // new DrawerHeader(children: [new Text('Stocks')]),
+ new MenuItem(
+ key: 'Stock list',
+ icon: 'action/assessment',
+ children: [new Text('Stock List')]),
+ new MenuItem(
+ key: 'Account Balance',
+ icon: 'action/account_balance',
+ children: [new Text('Account Balance')]),
+ // new MenuDivider(key: 'div1'),
+ // new MenuItem(
+ // key: 'Optimistic Menu Item',
+ // icon: 'action/thumb_up',
+ // onGestureTap: (event) => _handleStockModeChange(StockMode.Optimistic),
+ // children: [
+ // new ParentDataNode(new Text('Optimistic'), _flex1),
+ // new Radio(key: 'optimistic-radio', value: StockMode.Optimistic, groupValue: _stockMode, onChanged: _handleStockModeChange)
+ // ]),
+ // new MenuItem(
+ // key: 'Pessimistic Menu Item',
+ // icon: 'action/thumb_down',
+ // onGestureTap: (event) => _handleStockModeChange(StockMode.Pessimistic),
+ // children: [
+ // new ParentDataNode(new Text('Pessimistic'), _flex1),
+ // new Radio(key: 'pessimistic-radio', value: StockMode.Pessimistic, groupValue: _stockMode, onChanged: _handleStockModeChange)
+ // ]),
+ // new MenuDivider(key: 'div2'),
+ new MenuItem(
+ key: 'Settings',
+ icon: 'action/settings',
+ children: [new Text('Settings')]),
+ new MenuItem(
+ key: 'Help & Feedback',
+ icon: 'action/help',
+ children: [new Text('Help & Feedback')])
+ ]
);
}
« no previous file with comments | « no previous file | sky/sdk/lib/framework/components2/ink_well.dart » ('j') | sky/sdk/lib/framework/components2/menu_item.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698