Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1165983002: Stub out InkWell and implement Sky’s fn2 menu item (Closed)

Created:
5 years, 6 months ago by jackson
Modified:
5 years, 6 months ago
Reviewers:
Hixie, abarth-chromium
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Refactor EdgeDims and make BoxDecoration const #

Patch Set 3 : Fix whitespace #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -185 lines) Patch
M sky/examples/stocks2/lib/stock_app.dart View 2 chunks +39 lines, -40 lines 0 comments Download
M sky/sdk/lib/framework/components2/ink_well.dart View 1 chunk +102 lines, -99 lines 0 comments Download
M sky/sdk/lib/framework/components2/menu_item.dart View 1 2 chunks +21 lines, -36 lines 0 comments Download
M sky/sdk/lib/framework/components2/tool_bar.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/rendering/box.dart View 1 2 3 1 chunk +7 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jackson
5 years, 6 months ago (2015-06-04 17:38:54 UTC) #1
abarth-chromium
lgtm
5 years, 6 months ago (2015-06-04 17:42:16 UTC) #2
Hixie
lgtm https://codereview.chromium.org/1165983002/diff/1/sky/sdk/lib/framework/components2/menu_item.dart File sky/sdk/lib/framework/components2/menu_item.dart (right): https://codereview.chromium.org/1165983002/diff/1/sky/sdk/lib/framework/components2/menu_item.dart#newcode14 sky/sdk/lib/framework/components2/menu_item.dart:14: static final BoxDecoration highlightDecoration = new BoxDecoration( Can ...
5 years, 6 months ago (2015-06-04 17:53:09 UTC) #3
Hixie
5 years, 6 months ago (2015-06-04 17:53:11 UTC) #4
jackson
https://codereview.chromium.org/1165983002/diff/1/sky/sdk/lib/framework/components2/menu_item.dart File sky/sdk/lib/framework/components2/menu_item.dart (right): https://codereview.chromium.org/1165983002/diff/1/sky/sdk/lib/framework/components2/menu_item.dart#newcode14 sky/sdk/lib/framework/components2/menu_item.dart:14: static final BoxDecoration highlightDecoration = new BoxDecoration( On 2015/06/04 ...
5 years, 6 months ago (2015-06-04 18:03:24 UTC) #5
jackson
5 years, 6 months ago (2015-06-04 18:04:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
279740c5d26a21d41d5429c4cfafb43ffca152a6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698