Componentize StartupTaskRunnerService

Componentize StartupTaskRunnerService

Change constructor of StartupTaskRunnerService to directly receive the
base::SequencedTaskRunner to use for the deferred task runner that is
injected by the factory.

Move the startup_task_runner_service.{cc,h} to //components/bookmarks
and the factory to //chrome/browser/bookmarks as this code is only used
by the bookmark code.

BUG=485146
Committed: https://crrev.com/449b50e4c26610c0309fe6fc5159c66f1f5ecca3
Cr-Commit-Position: refs/heads/master@{#333705}

[sdefresne, 2015-06-04 08:11:45]

sdefresne@chromium.org changed reviewers:
+ noms@chromium.org, shess@chromium.org, sky@chromium.org

[sdefresne, 2015-06-04 08:11:46]

noms@ can you review:
  chrome/browser/profiles/profile_browsertest.cc
  chrome/browser/profiles/profile_manager.cc
  chrome/browser/profiles/startup_task_runner_service.cc
  chrome/browser/profiles/startup_task_runner_service.h
  chrome/browser/profiles/startup_task_runner_service_factory.cc
  chrome/browser/profiles/startup_task_runner_service_factory.h

shess@ can you review:
  chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc

sky@ can you review:
  chrome/browser/bookmarks/bookmark_model_factory.cc
  chrome/browser/bookmarks/startup_task_runner_service_factory.cc
  chrome/browser/bookmarks/startup_task_runner_service_factory.h
  components/bookmarms/browser/startup_task_runner_service.cc
  components/bookmarms/browser/startup_task_runner_service.h

[sdefresne, 2015-06-04 08:13:20]

Patchset #1 (id:1) has been deleted

[sky, 2015-06-04 19:32:43]

LGTM

[Scott Hess - ex-Googler, 2015-06-04 21:11:43]

I was going to suggest simply removing the code from the safe-browsing test, but
it looks like it's there intentionally (bug 312838).  So I guess LGTM.

IMHO the need to do this random thing to use profiles correctly seems kind of
like a bug, to me.

[sdefresne, 2015-06-08 07:29:46]

noms: ping?

[sdefresne, 2015-06-09 08:54:57]

sdefresne@chromium.org changed reviewers:
+ erg@chromium.org
- noms@chromium.org

[sdefresne, 2015-06-09 08:55:56]

-noms, +erg: please review as OWNERS of //chrome/browser/profiles

[Elliot Glaysher, 2015-06-09 17:04:47]

lgtm

[sdefresne, 2015-06-10 08:01:59]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2015-06-10 08:02:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1165913004/20001

[commit-bot: I haz the power, 2015-06-10 09:12:41]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2015-06-10 09:13:43]

Patchset 1 (id:??) landed as
https://crrev.com/449b50e4c26610c0309fe6fc5159c66f1f5ecca3
Cr-Commit-Position: refs/heads/master@{#333705}

[tfarina, 2015-06-10 23:18:26]

https://codereview.chromium.org/1165913004/diff/20001/components/bookmarks/br...
File components/bookmarks/browser/startup_task_runner_service.h (right):

https://codereview.chromium.org/1165913004/diff/20001/components/bookmarks/br...
components/bookmarks/browser/startup_task_runner_service.h:20: class
StartupTaskRunnerService : public base::NonThreadSafe,
Scott, should we put this in bookmarks namespace? If yes, I will do it.

[sky, 2015-06-10 23:37:02]

https://codereview.chromium.org/1165913004/diff/20001/components/bookmarks/br...
File components/bookmarks/browser/startup_task_runner_service.h (right):

https://codereview.chromium.org/1165913004/diff/20001/components/bookmarks/br...
components/bookmarks/browser/startup_task_runner_service.h:20: class
StartupTaskRunnerService : public base::NonThreadSafe,
On 2015/06/10 23:18:26, tfarina wrote:
> Scott, should we put this in bookmarks namespace? If yes, I will do it.

Sure.