components/feedback/feedback_uploader_unittest.cc - Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/feedback/feedback_uploader_unittest.cc

Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Finish renaming profile -> context Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/feedback/feedback_data_unittest.cc ('k') | components/keyed_service/content/browser_context_keyed_service_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/feedback/feedback_uploader_unittest.cc

diff --git a/components/feedback/feedback_uploader_unittest.cc b/components/feedback/feedback_uploader_unittest.cc

index 4985129f153ae0484db4011789c7822c3eb52cfd..bd744854c2e5302d6c390af70fff0eb9893899b0 100644

--- a/components/feedback/feedback_uploader_unittest.cc

+++ b/components/feedback/feedback_uploader_unittest.cc

@@ -7,6 +7,7 @@

#include <set>

#include "base/bind.h"

+#include "base/memory/scoped_ptr.h"

#include "base/message_loop/message_loop.h"

#include "base/prefs/testing_pref_service.h"

#include "base/run_loop.h"

@@ -30,8 +31,9 @@ const char kReportFive[] = "five";

const base::TimeDelta kRetryDelayForTest =

base::TimeDelta::FromMilliseconds(100);

-KeyedService* CreateFeedbackUploaderService(content::BrowserContext* context) {

- return new feedback::FeedbackUploaderChrome(context);

+scoped_ptr<KeyedService> CreateFeedbackUploaderService(

+ content::BrowserContext* context) {

+ return make_scoped_ptr(new feedback::FeedbackUploaderChrome(context));

}

} // namespace