chrome/browser/ui/sync/one_click_signin_sync_starter_unittest.cc - Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sync/one_click_signin_sync_starter_unittest.cc

Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Finish renaming profile -> context Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc ('k') | chrome/browser/ui/tabs/pinned_tab_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/sync/one_click_signin_sync_starter_unittest.cc

diff --git a/chrome/browser/ui/sync/one_click_signin_sync_starter_unittest.cc b/chrome/browser/ui/sync/one_click_signin_sync_starter_unittest.cc

index a2720e7ff9069a4db9b6f457da41883c127a9f91..f5c74b956074b732533db3bf84babce25c339382 100644

--- a/chrome/browser/ui/sync/one_click_signin_sync_starter_unittest.cc

+++ b/chrome/browser/ui/sync/one_click_signin_sync_starter_unittest.cc

@@ -94,8 +94,10 @@ class OneClickSigninSyncStarterTest : public ChromeRenderViewHostTestHarness {

int succeeded_count_;

private:

- static KeyedService* BuildSigninManager(content::BrowserContext* profile) {

- return new FakeSigninManager(static_cast<Profile*>(profile));

+ static scoped_ptr<KeyedService> BuildSigninManager(

+ content::BrowserContext* profile) {

+ return make_scoped_ptr(

+ new FakeSigninManager(static_cast<Profile*>(profile)));

}

DISALLOW_COPY_AND_ASSIGN(OneClickSigninSyncStarterTest);