chrome/browser/sessions/persistent_tab_restore_service_unittest.cc - Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sessions/persistent_tab_restore_service_unittest.cc

Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Finish renaming profile -> context Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/services/gcm/gcm_profile_service_unittest.cc ('k') | chrome/browser/sessions/session_service_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sessions/persistent_tab_restore_service_unittest.cc

diff --git a/chrome/browser/sessions/persistent_tab_restore_service_unittest.cc b/chrome/browser/sessions/persistent_tab_restore_service_unittest.cc

index fe4a05a1099ad491d1a9b331d38010e2138c53ba..cadb88b41fee58a6bd3164e35bafbdefcce5d9aa 100644

--- a/chrome/browser/sessions/persistent_tab_restore_service_unittest.cc

+++ b/chrome/browser/sessions/persistent_tab_restore_service_unittest.cc

@@ -146,9 +146,8 @@ class PersistentTabRestoreServiceTest : public ChromeRenderViewHostTestHarness {

// way of AddWindowWithOneTabToSessionService. If |pinned| is true, the

// tab is marked as pinned in the session service.

void CreateSessionServiceWithOneWindow(bool pinned) {

- // The profile takes ownership of this.

- SessionService* session_service = new SessionService(profile());

- SessionServiceFactory::SetForTestProfile(profile(), session_service);

+ scoped_ptr<SessionService> session_service(new SessionService(profile()));

+ SessionServiceFactory::SetForTestProfile(profile(), session_service.Pass());

AddWindowWithOneTabToSessionService(pinned);

« no previous file with comments | « chrome/browser/services/gcm/gcm_profile_service_unittest.cc ('k') | chrome/browser/sessions/session_service_factory.h » ('j') | no next file with comments »