chrome/browser/password_manager/test_password_store_service.cc - Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/test_password_store_service.cc

Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Finish renaming profile -> context Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/test_password_store_service.h ('k') | chrome/browser/policy/cloud/cloud_policy_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/test_password_store_service.cc

diff --git a/chrome/browser/password_manager/test_password_store_service.cc b/chrome/browser/password_manager/test_password_store_service.cc

index af96bc3bf0cd168d50f1d22ae7e7805805ddf547..ef5ad2471bc45b3b5b269de8dd2f807fc256757a 100644

--- a/chrome/browser/password_manager/test_password_store_service.cc

+++ b/chrome/browser/password_manager/test_password_store_service.cc

@@ -7,13 +7,13 @@

#include "components/password_manager/core/browser/test_password_store.h"

// static

-KeyedService* TestPasswordStoreService::Build(

+scoped_ptr<KeyedService> TestPasswordStoreService::Build(

content::BrowserContext* /*profile*/) {

scoped_refptr<password_manager::PasswordStore> store(

new password_manager::TestPasswordStore);

if (!store.get() || !store->Init(syncer::SyncableService::StartSyncFlare()))

return nullptr;

- return new TestPasswordStoreService(store);

+ return scoped_ptr<KeyedService>(new TestPasswordStoreService(store));

}

TestPasswordStoreService::TestPasswordStoreService(