chrome/browser/history/web_history_service_unittest.cc - Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/web_history_service_unittest.cc

Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Finish renaming profile -> context Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/test_extension_system.cc ('k') | chrome/browser/invalidation/profile_invalidation_provider_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/history/web_history_service_unittest.cc

diff --git a/chrome/browser/history/web_history_service_unittest.cc b/chrome/browser/history/web_history_service_unittest.cc

index 6bbb54a5f74b247482712368e8906859897d897d..3d20a897c37bdf8e7749baa588dfa3abd5676889 100644

--- a/chrome/browser/history/web_history_service_unittest.cc

+++ b/chrome/browser/history/web_history_service_unittest.cc

@@ -195,12 +195,13 @@ std::string TestingWebHistoryService::GetExpectedAudioHistoryValue() {

return "false";

}

-static KeyedService* BuildWebHistoryService(content::BrowserContext* context) {

+static scoped_ptr<KeyedService> BuildWebHistoryService(

+ content::BrowserContext* context) {

Profile* profile = static_cast<Profile*>(context);

- return new TestingWebHistoryService(

+ return make_scoped_ptr(new TestingWebHistoryService(

ProfileOAuth2TokenServiceFactory::GetForProfile(profile),

SigninManagerFactory::GetForProfile(profile),

- profile->GetRequestContext());

+ profile->GetRequestContext()));

}

} // namespace