chrome/browser/extensions/extension_action_test_util.cc - Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_action_test_util.cc

Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Finish renaming profile -> context Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/storage/settings_sync_unittest.cc ('k') | chrome/browser/extensions/extension_garbage_collector_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_action_test_util.cc

diff --git a/chrome/browser/extensions/extension_action_test_util.cc b/chrome/browser/extensions/extension_action_test_util.cc

index da6756e2a5bf426b3a8ce48856c8499668dba5b2..6a6eddcb33d8e4718a795818b3b8e817e2b921a2 100644

--- a/chrome/browser/extensions/extension_action_test_util.cc

+++ b/chrome/browser/extensions/extension_action_test_util.cc

@@ -4,6 +4,7 @@

#include "chrome/browser/extensions/extension_action_test_util.h"

+#include "base/memory/scoped_ptr.h"

#include "base/run_loop.h"

#include "chrome/browser/extensions/extension_action.h"

#include "chrome/browser/extensions/extension_action_manager.h"

@@ -69,10 +70,10 @@ size_t GetPageActionCount(content::WebContents* web_contents,

}

// Creates a new ExtensionToolbarModel for the given |context|.

-KeyedService* BuildToolbarModel(content::BrowserContext* context) {

- return new extensions::ExtensionToolbarModel(

+scoped_ptr<KeyedService> BuildToolbarModel(content::BrowserContext* context) {

+ return make_scoped_ptr(new extensions::ExtensionToolbarModel(

Profile::FromBrowserContext(context),

- extensions::ExtensionPrefs::Get(context));

+ extensions::ExtensionPrefs::Get(context)));

}

// Creates a new ExtensionToolbarModel for the given profile, optionally