chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_api_unittest.cc - Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_api_unittest.cc

Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Finish renaming profile -> context Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/socket/socket_api_unittest.cc ('k') | chrome/browser/extensions/api/storage/settings_sync_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_api_unittest.cc

diff --git a/chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_api_unittest.cc b/chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_api_unittest.cc

index 1a31f0920bf115c2b38f310f5909fa972700069a..a18abba39565c4bcefd3c8ddf99c736bd22eceb4 100644

--- a/chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_api_unittest.cc

+++ b/chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_api_unittest.cc

@@ -2,6 +2,7 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

+#include "base/memory/scoped_ptr.h"

#include "base/values.h"

#include "chrome/browser/browser_process_impl.h"

#include "chrome/browser/extensions/extension_api_unittest.h"

@@ -18,7 +19,7 @@

namespace extensions {

namespace core_api {

-static KeyedService* ApiResourceManagerTestFactory(

+static scoped_ptr<KeyedService> ApiResourceManagerTestFactory(

content::BrowserContext* context) {

content::BrowserThread::ID id;

CHECK(content::BrowserThread::GetCurrentThreadIdentifier(&id));

@@ -26,7 +27,7 @@ static KeyedService* ApiResourceManagerTestFactory(

ResumableTCPSocket>::CreateApiResourceManagerForTest(context, id);

}

-static KeyedService* ApiResourceManagerTestServerFactory(

+static scoped_ptr<KeyedService> ApiResourceManagerTestServerFactory(

content::BrowserContext* context) {

content::BrowserThread::ID id;

CHECK(content::BrowserThread::GetCurrentThreadIdentifier(&id));