chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager_unittest.cc - Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager_unittest.cc

Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Finish renaming profile -> context Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc ('k') | chrome/browser/extensions/api/socket/socket_api_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager_unittest.cc

diff --git a/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager_unittest.cc b/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager_unittest.cc

index 322ef967c3a1e68de825677e88307adf03fb6255..b044515d98f1e5b46a10e41cee20d1e736190595 100644

--- a/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager_unittest.cc

+++ b/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager_unittest.cc

@@ -19,20 +19,14 @@

namespace extensions {

-namespace {

-KeyedService* CreateProfileSyncServiceMock(content::BrowserContext* profile) {

- return NULL;

-} // namespace

// Adds a listener and removes it.

TEST(SignedInDevicesManager, UpdateListener) {

content::TestBrowserThreadBundle thread_bundle;

scoped_ptr<TestingProfile> profile(new TestingProfile());

SigninManagerFactory::GetForProfile(profile.get())->

SetAuthenticatedAccountInfo("gaia_id", "foo");

- ProfileSyncServiceFactory::GetInstance()->SetTestingFactory(

- profile.get(), CreateProfileSyncServiceMock);

+ ProfileSyncServiceFactory::GetInstance()->SetTestingFactory(profile.get(),

+ nullptr);

SignedInDevicesManager manager(profile.get());

EventListenerInfo info(api::signed_in_devices::OnDeviceInfoChange::kEventName,