chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc - Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc

Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Finish renaming profile -> context Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/networking_private/networking_private_apitest.cc ('k') | chrome/browser/extensions/api/networking_private/networking_private_service_client_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc

diff --git a/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc b/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc

index 89a201f9dc8436c122cb2ca936c0d5ee4833fced..17f905028bc18f4216a30f8af398749d206308e9 100644

--- a/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc

+++ b/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc

@@ -6,6 +6,7 @@

#include "base/callback.h"

#include "base/command_line.h"

#include "base/macros.h"

+#include "base/memory/scoped_ptr.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/chromeos/login/helper.h"

#include "chrome/browser/chromeos/net/network_portal_detector_test_impl.h"

@@ -229,10 +230,11 @@ class NetworkingPrivateChromeOSApiTest : public ExtensionApiTest {

state, true /* add_to_visible */);

}

- static KeyedService* CreateNetworkingPrivateServiceClient(

- content::BrowserContext* profile) {

+ static scoped_ptr<KeyedService> CreateNetworkingPrivateServiceClient(

+ content::BrowserContext* context) {

scoped_ptr<CryptoVerifyStub> crypto_verify(new CryptoVerifyStub);

- return new NetworkingPrivateChromeOS(profile, crypto_verify.Pass());

+ return make_scoped_ptr(

+ new NetworkingPrivateChromeOS(context, crypto_verify.Pass()));

}

void SetUpOnMainThread() override {