chrome/browser/download/download_ui_controller_unittest.cc - Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_ui_controller_unittest.cc

Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Finish renaming profile -> context Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_shelf_unittest.cc ('k') | chrome/browser/extensions/active_script_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_ui_controller_unittest.cc

diff --git a/chrome/browser/download/download_ui_controller_unittest.cc b/chrome/browser/download/download_ui_controller_unittest.cc

index d29878d44db720204023bca7df28424f74e78f8d..015f93a26118beb9fa8fdea3733b535f8ad385f7 100644

--- a/chrome/browser/download/download_ui_controller_unittest.cc

+++ b/chrome/browser/download/download_ui_controller_unittest.cc

@@ -135,7 +135,7 @@ class DownloadUIControllerTest : public ChromeRenderViewHostTestHarness {

};

// Constructs and returns a TestDownloadService.

- static KeyedService* TestingDownloadServiceFactory(

+ static scoped_ptr<KeyedService> TestingDownloadServiceFactory(

content::BrowserContext* browser_context);

scoped_ptr<MockDownloadManager> manager_;

@@ -148,9 +148,11 @@ class DownloadUIControllerTest : public ChromeRenderViewHostTestHarness {

};

// static

-KeyedService* DownloadUIControllerTest::TestingDownloadServiceFactory(

+scoped_ptr<KeyedService>

+DownloadUIControllerTest::TestingDownloadServiceFactory(

content::BrowserContext* browser_context) {

- return new TestDownloadService(Profile::FromBrowserContext(browser_context));

+ return make_scoped_ptr(

+ new TestDownloadService(Profile::FromBrowserContext(browser_context)));

}

DownloadUIControllerTest::DownloadUIControllerTest()