chrome/browser/browsing_data/browsing_data_remover_unittest.cc - Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/browsing_data_remover_unittest.cc

Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Finish renaming profile -> context Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autocomplete/history_url_provider_unittest.cc ('k') | chrome/browser/chromeos/file_system_provider/fileapi/file_stream_reader_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/browsing_data_remover_unittest.cc

diff --git a/chrome/browser/browsing_data/browsing_data_remover_unittest.cc b/chrome/browser/browsing_data/browsing_data_remover_unittest.cc

index 0531d87453b35fed9d2d0d01766f3c960e71ad5c..e6d7c9a08195f4e2ee681b62953ec4d2e4d38518 100644

--- a/chrome/browser/browsing_data/browsing_data_remover_unittest.cc

+++ b/chrome/browser/browsing_data/browsing_data_remover_unittest.cc

@@ -744,7 +744,7 @@ struct TestingDomainReliabilityServiceFactoryUserData

const void* TestingDomainReliabilityServiceFactoryUserData::kKey =

&TestingDomainReliabilityServiceFactoryUserData::kKey;

-KeyedService* TestingDomainReliabilityServiceFactoryFunction(

+scoped_ptr<KeyedService> TestingDomainReliabilityServiceFactoryFunction(

content::BrowserContext* context) {

const void* kKey = TestingDomainReliabilityServiceFactoryUserData::kKey;

@@ -756,7 +756,7 @@ KeyedService* TestingDomainReliabilityServiceFactoryFunction(

EXPECT_FALSE(data->attached);

data->attached = true;

- return data->service;

+ return make_scoped_ptr(data->service);

}

class ClearDomainReliabilityTester {