Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: chrome/browser/ui/bookmarks/bookmark_unittest.cc

Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Finish renaming profile -> context Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/memory/scoped_ptr.h"
5 #include "chrome/browser/search_engines/template_url_service_factory.h" 6 #include "chrome/browser/search_engines/template_url_service_factory.h"
6 #include "chrome/browser/ui/tabs/tab_strip_model.h" 7 #include "chrome/browser/ui/tabs/tab_strip_model.h"
7 #include "chrome/common/url_constants.h" 8 #include "chrome/common/url_constants.h"
8 #include "chrome/test/base/browser_with_test_window_test.h" 9 #include "chrome/test/base/browser_with_test_window_test.h"
9 #include "components/search_engines/search_terms_data.h" 10 #include "components/search_engines/search_terms_data.h"
10 #include "components/search_engines/template_url_service.h" 11 #include "components/search_engines/template_url_service.h"
11 #include "components/search_engines/template_url_service_client.h" 12 #include "components/search_engines/template_url_service_client.h"
12 #include "content/public/browser/navigation_entry.h" 13 #include "content/public/browser/navigation_entry.h"
13 #include "content/public/browser/web_contents.h" 14 #include "content/public/browser/web_contents.h"
14 15
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 TestingProfile* CreateProfile() override { 51 TestingProfile* CreateProfile() override {
51 TestingProfile* profile = BrowserWithTestWindowTest::CreateProfile(); 52 TestingProfile* profile = BrowserWithTestWindowTest::CreateProfile();
52 // TemplateURLService is normally NULL during testing. Instant extended 53 // TemplateURLService is normally NULL during testing. Instant extended
53 // needs this service so set a custom factory function. 54 // needs this service so set a custom factory function.
54 TemplateURLServiceFactory::GetInstance()->SetTestingFactory( 55 TemplateURLServiceFactory::GetInstance()->SetTestingFactory(
55 profile, &BookmarkInstantExtendedTest::CreateTemplateURLService); 56 profile, &BookmarkInstantExtendedTest::CreateTemplateURLService);
56 return profile; 57 return profile;
57 } 58 }
58 59
59 private: 60 private:
60 static KeyedService* CreateTemplateURLService( 61 static scoped_ptr<KeyedService> CreateTemplateURLService(
61 content::BrowserContext* profile) { 62 content::BrowserContext* profile) {
62 return new TemplateURLService( 63 return make_scoped_ptr(new TemplateURLService(
63 static_cast<Profile*>(profile)->GetPrefs(), 64 static_cast<Profile*>(profile)->GetPrefs(),
64 make_scoped_ptr(new SearchTermsData), NULL, 65 make_scoped_ptr(new SearchTermsData), NULL,
65 scoped_ptr<TemplateURLServiceClient>(), NULL, NULL, base::Closure()); 66 scoped_ptr<TemplateURLServiceClient>(), NULL, NULL, base::Closure()));
66 } 67 }
67 68
68 DISALLOW_COPY_AND_ASSIGN(BookmarkInstantExtendedTest); 69 DISALLOW_COPY_AND_ASSIGN(BookmarkInstantExtendedTest);
69 }; 70 };
70 71
71 // Verify that in instant extended mode the detached bookmark bar is visible on 72 // Verify that in instant extended mode the detached bookmark bar is visible on
72 // the new tab page. 73 // the new tab page.
73 TEST_F(BookmarkInstantExtendedTest, DetachedBookmarkBarOnNTP) { 74 TEST_F(BookmarkInstantExtendedTest, DetachedBookmarkBarOnNTP) {
74 AddTab(browser(), GURL(chrome::kChromeUINewTabURL)); 75 AddTab(browser(), GURL(chrome::kChromeUINewTabURL));
75 EXPECT_EQ(BookmarkBar::DETACHED, browser()->bookmark_bar_state()); 76 EXPECT_EQ(BookmarkBar::DETACHED, browser()->bookmark_bar_state());
76 } 77 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698