[Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions.

chrome/browser/extensions/active_script_controller_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <map>
 
 #include "base/values.h"
 #include "chrome/browser/extensions/active_script_controller.h"
 #include "chrome/browser/extensions/active_tab_permission_granter.h"
 #include "chrome/browser/extensions/api/extension_action/extension_action_api.h"
@@ skipping 14 matching lines @@
 #include "extensions/common/manifest.h"
 #include "extensions/common/user_script.h"
 #include "extensions/common/value_builder.h"
 
 namespace extensions {
 
 namespace {
 
 const char kAllHostsPermission[] = "*://*/*";
 
-// We skip syncing for testing purposes.
-KeyedService* BuildSyncService(content::BrowserContext* context) {
-  return nullptr;
-}
-
 }  // namespace
 
 // Unittests for the ActiveScriptController mostly test the internal logic
 // of the controller itself (when to allow/deny extension script injection).
 // Testing real injection is allowed/denied as expected (i.e., that the
 // ActiveScriptController correctly interfaces in the system) is done in the
 // ActiveScriptControllerBrowserTests.
 class ActiveScriptControllerUnitTest : public ChromeRenderViewHostTestHarness {
  protected:
   ActiveScriptControllerUnitTest();
@@ skipping 112 matching lines @@
 }
 
 void ActiveScriptControllerUnitTest::IncrementExecutionCount(
     const std::string& extension_id) {
   ++extension_executions_[extension_id];
 }
 
 void ActiveScriptControllerUnitTest::SetUp() {
   ChromeRenderViewHostTestHarness::SetUp();
 
-  ExtensionSyncServiceFactory::GetInstance()->SetTestingFactory(
-      profile(), &BuildSyncService);
+  // Skip syncing for testing purposes.
+  ExtensionSyncServiceFactory::GetInstance()->SetTestingFactory(profile(),
+                                                                nullptr);
 
   TabHelper::CreateForWebContents(web_contents());
   TabHelper* tab_helper = TabHelper::FromWebContents(web_contents());
   // These should never be NULL.
   DCHECK(tab_helper);
   active_script_controller_ = tab_helper->active_script_controller();
   DCHECK(active_script_controller_);
 }
 
 // Test that extensions with all_hosts require permission to execute, and, once
@@ skipping 236 matching lines @@
   EXPECT_TRUE(RequiresUserConsent(extension));
   // Different subdomain...
   NavigateAndCommit(GURL("https://en.google.com/foo/bar"));
   EXPECT_TRUE(RequiresUserConsent(extension));
   // Only the "always run" origin should be allowed to run without user consent.
   NavigateAndCommit(GURL("https://www.google.com/foo/bar"));
   EXPECT_FALSE(RequiresUserConsent(extension));
 }
 
 }  // namespace extensions