Generate the TransitionElementsStub using Crankshaft

src/hydrogen.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 245 matching lines @@
   HBasicBlock* entry_block() const { return entry_block_; }
   HEnvironment* start_environment() const { return start_environment_; }
 
   void InitializeInferredTypes();
   void InsertTypeConversions();
   void MergeRemovableSimulates();
   void InsertRepresentationChanges();
   void MarkDeoptimizeOnUndefined();
   void ComputeMinusZeroChecks();
   void ComputeSafeUint32Operations();
+  void GlobalValueNumbering();
   bool ProcessArgumentsObject();
   void EliminateRedundantPhis();
   void EliminateUnreachablePhis();
   void Canonicalize();
   void OrderBlocks();
   void AssignDominators();
   void ReplaceCheckedValues();
   void EliminateRedundantBoundsChecks();
   void DehoistSimpleArrayIndexComputations();
   void DeadCodeElimination();
@@ skipping 567 matching lines @@
   // When inlining HEnterInlined instruction corresponding to the function
   // entry.
   HEnterInlined* entry_;
 
   HArgumentsElements* arguments_elements_;
 
   FunctionState* outer_;
 };
 
 
+class LoopBodyBuilder {

[Michael Starzinger, 2013/01/31 13:15:10]

The LoopBodyBuilder seems to be left-over, drop it.

[danno, 2013/01/31 15:53:25]

Done.

+ public:
+  virtual ~LoopBodyBuilder() {}
+  virtual void Build(HValue* current) = 0;
+};
+
+class CopyElementLoopBodyBuilder;

[Michael Starzinger, 2013/01/31 13:15:10]

The CopyElementLoopBodyBuilder seems to be a left-over, drop it.

[danno, 2013/01/31 15:53:25]

Done.

[danno, 2013/01/31 15:53:25]

Done.

+
 class HGraphBuilder {
  public:
   explicit HGraphBuilder(CompilationInfo* info)
       : info_(info), graph_(NULL), current_block_(NULL) {}
   virtual ~HGraphBuilder() {}
 
   HBasicBlock* current_block() const { return current_block_; }
   void set_current_block(HBasicBlock* block) { current_block_ = block; }
   HEnvironment* environment() const {
     return current_block()->last_environment();
   }
   Zone* zone() const { return info_->zone(); }
   HGraph* graph() { return graph_; }
 
   HGraph* CreateGraph();
 
   // Adding instructions.
   HInstruction* AddInstruction(HInstruction* instr);
   void AddSimulate(BailoutId id,
                    RemovableSimulate removable = FIXED_SIMULATE);
 
  protected:
   virtual bool BuildGraph() = 0;
 
+  HBasicBlock* CreateBasicBlock(HEnvironment* env);
+  HBasicBlock* CreateLoopHeaderBlock();
+
   // Building common constructs
   HInstruction* BuildExternalArrayElementAccess(
       HValue* external_elements,
       HValue* checked_key,
       HValue* val,
       HValue* dependency,
       ElementsKind elements_kind,
       bool is_store);
 
   HInstruction* BuildFastElementAccess(
       HValue* elements,
       HValue* checked_key,
       HValue* val,
       HValue* dependency,
       ElementsKind elements_kind,
       bool is_store);
 
   HInstruction* BuildUncheckedMonomorphicElementAccess(
       HValue* object,
       HValue* key,
       HValue* val,
       HCheckMaps* mapcheck,
       bool is_js_array,
       ElementsKind elements_kind,
       bool is_store,
       Representation checked_index_representation = Representation::None());
 
+  HValue* IntegerConstant(int value);

[Michael Starzinger, 2013/01/31 13:15:10]

There already is a HGraph::GetConstantInt32(), we could reuse that for the
well-known constants "0" and "1". It makes sure constants are inserted at the
top of the graph.

[danno, 2013/01/31 15:53:25]

Done.

+  HValue* Zero() { return IntegerConstant(0); }
+  HValue* One() { return IntegerConstant(1); }
+
+  class IfBuilder {
+   public:
+    IfBuilder(HGraphBuilder* builder,
+              BailoutId id = BailoutId::StubEntry());
+    ~IfBuilder() {
+      if (!finished_) End();
+    }
+
+    void BeginTrue(HValue* left, HValue* right, Token::Value token);
+    void BeginFalse();
+    void End();
+
+   private:
+    HGraphBuilder* builder_;
+    bool finished_;
+    HEnvironment* true_env_;
+    HEnvironment* false_env_;
+    HEnvironment* merge_env_;
+    HBasicBlock* true_block_;
+    HBasicBlock* false_block_;
+    HBasicBlock* merge_block_;
+    BailoutId id_;
+
+    Zone* zone() { return builder_->zone(); }
+  };
+
+  class LoopBuilder {
+   public:
+    enum Direction {
+      kPreIncrement,
+      kPostIncrement,
+      kPreDecrement,
+      kPostDecrement
+    };
+
+    LoopBuilder(HGraphBuilder* builder,
+                HValue* context,
+                Direction direction,
+                BailoutId id = BailoutId::StubEntry());
+    ~LoopBuilder() {
+      ASSERT(finished_);
+    }
+
+    HValue* BeginBody(HValue* initial, HValue* terminating, Token::Value token);
+    void EndBody();
+
+   private:
+    HGraphBuilder* builder_;
+    HValue* context_;
+    HInstruction* increment_;
+    HPhi* phi_;
+    HEnvironment* body_env_;
+    HEnvironment* exit_env_;
+    HBasicBlock* header_block_;
+    HBasicBlock* body_block_;
+    HBasicBlock* exit_block_;
+    Direction direction_;
+    BailoutId id_;
+    bool finished_;
+
+    Zone* zone() { return builder_->zone(); }
+  };
+
+  HValue* BuildAllocateElements(HContext* context,
+                                ElementsKind kind,
+                                HValue* capacity);
+
+  void BuildCopyElements(HContext* context,
+                         HValue* from_elements,
+                         ElementsKind from_elements_kind,
+                         HValue* to_elements,
+                         ElementsKind to_elements_kind,
+                         HValue* length);
+
  private:
+  friend class CopyElementLoopBodyBuilder;

[Michael Starzinger, 2013/01/31 13:15:10]

The CopyElementLoopBodyBuilder seems to be a left-over, drop it.

[danno, 2013/01/31 15:53:25]

Done.

   HGraphBuilder();
   CompilationInfo* info_;
   HGraph* graph_;
   HBasicBlock* current_block_;
 };
 
 
 class HOptimizedGraphBuilder: public HGraphBuilder, public AstVisitor {
  public:
   enum BreakType { BREAK, CONTINUE };
@@ skipping 211 matching lines @@
 
   static Representation ToRepresentation(TypeInfo info);
 
   void SetUpScope(Scope* scope);
   virtual void VisitStatements(ZoneList<Statement*>* statements);
 
 #define DECLARE_VISIT(type) virtual void Visit##type(type* node);
   AST_NODE_LIST(DECLARE_VISIT)
 #undef DECLARE_VISIT
 
-  HBasicBlock* CreateBasicBlock(HEnvironment* env);
-  HBasicBlock* CreateLoopHeaderBlock();
-
   // Helpers for flow graph construction.
   enum GlobalPropertyAccess {
     kUseCell,
     kUseGeneric
   };
   GlobalPropertyAccess LookupGlobalProperty(Variable* var,
                                             LookupResult* lookup,
                                             bool is_store);
 
   void EnsureArgumentsArePushedForAccess();
@@ skipping 428 matching lines @@
   const char* filename_;
   HeapStringAllocator string_allocator_;
   StringStream trace_;
   int indent_;
 };
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_HYDROGEN_H_