Issue 11659011: overscroll: Show the screenshot of the navigation-entry when doing overscroll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11659011: overscroll: Show the screenshot of the navigation-entry when doing overscroll. (Closed)

Created:
8 years ago by sadrul

Modified:
8 years ago

Reviewers:
sky

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

overscroll: Show the screenshot of the navigation-entry when doing overscroll. The navigation entries can retain a screenshot of the page before they were unloaded. Display that screenshot (when available) during the overscroll animation. BUG=160668 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174506

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -5 lines)			Patch
	M	content/browser/web_contents/web_contents_view_aura.cc	View		6 chunks	+31 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sadrul

Hi! This patch depends on the NavigationEntryImpl changes in https://codereview.chromium.org/11635059/, but should be reviewable independently.

8 years ago (2012-12-21 17:18:58 UTC) #1

LGTM

Expand Messages | Collapse Messages