chrome/browser/download/download_prefs.h - Issue 1165893004: [Downloads] Prevent dangerous files from being opened automatically.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_prefs.h

Issue 1165893004: [Downloads] Prevent dangerous files from being opened automatically. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use a blacklist instead of including all dangerous file types. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/download/download_extensions.cc ('K') | « chrome/browser/download/download_extensions.cc ('k') | chrome/browser/download/download_prefs.cc » ('j') | chrome/browser/download/download_prefs.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_prefs.h

diff --git a/chrome/browser/download/download_prefs.h b/chrome/browser/download/download_prefs.h

index e4d82594aa3b474cd1c8bfd2c5a6b5756221b7be..74efc32469f9b48aa1b43778bd39b38f9eb9e40a 100644

--- a/chrome/browser/download/download_prefs.h

+++ b/chrome/browser/download/download_prefs.h

@@ -66,8 +66,8 @@ class DownloadPrefs {

// |path.Extension()|.

bool IsAutoOpenEnabledBasedOnExtension(const base::FilePath& path) const;

- // Enables auto-open based on file extension. Returns true on success.

- // TODO(phajdan.jr): Add WARN_UNUSED_RESULT here.

+ // Enables auto-open based on file extension. Returns true on success. Will

+ // fail if the |file_name| isn't allowed to open automatically.

bool EnableAutoOpenBasedOnExtension(const base::FilePath& file_name);

// Disables auto-open based on file extension.