chrome/browser/download/download_extensions.h - Issue 1165893004: [Downloads] Prevent dangerous files from being opened automatically.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_extensions.h

Issue 1165893004: [Downloads] Prevent dangerous files from being opened automatically. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use a blacklist instead of including all dangerous file types. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_commands.cc ('k') | chrome/browser/download/download_extensions.cc » ('j') | chrome/browser/download/download_extensions.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_extensions.h

diff --git a/chrome/browser/download/download_extensions.h b/chrome/browser/download/download_extensions.h

index 67980caa662baa02bd5ad6c19fe121386a15eda4..93fcb78d09f39773731f5b582a169fb7650726a9 100644

--- a/chrome/browser/download/download_extensions.h

+++ b/chrome/browser/download/download_extensions.h

@@ -20,6 +20,11 @@ enum DownloadDangerLevel {

// Determine the download danger level of a file.

DownloadDangerLevel GetFileDangerLevel(const base::FilePath& path);

+// Returns true if the file specified by |path| is allowed to open

+// automatically. Most file types can be set to open automatically, but some

+// executable file types may not.

+bool IsAllowedToOpenAutomatically(const base::FilePath& path);

// Tests if we think the server means for this mime_type to be executable.

bool IsExecutableMimeType(const std::string& mime_type);