[Telemetry] Remove internal dependencies on BuildbotOutputFormatter

[Telemetry] Remove internal dependencies on BuildbotOutputFormatter

This CL picks up the value serialization changes from crrev.com/1157793003 as
well as the refactor of story_runner_unittest so that it no longer depends on
BuildbotOutputFormatter.

As a result, there are no remaining dependencies on BuildbotOutputFormatter in
Telemetry, save for results_options.py, which allows for consumers to continue
to use BuildbotOutputFormatter for the time being.

BUG=477056
R=nednguyen

Committed: https://crrev.com/8507ca60f46cd2a05482d3f484d8dc6ba7cd403f
Cr-Commit-Position: refs/heads/master@{#333069}

[eakuefner, 2015-06-05 02:42:38]

The CQ bit was checked by eakuefner@chromium.org to run a CQ dry run

[eakuefner, 2015-06-05 02:43:04]

PTAL. This lands all the parts of the BuildbotOutputFormatter patch save for the
deletion of BBOF itself and the modification of results_options.

[commit-bot: I haz the power, 2015-06-05 02:43:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1165883003/1

[commit-bot: I haz the power, 2015-06-05 05:17:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-05 05:17:40]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[nednguyen, 2015-06-05 14:58:08]

https://codereview.chromium.org/1165883003/diff/1/tools/telemetry/telemetry/v...
File tools/telemetry/telemetry/value/failure.py (right):

https://codereview.chromium.org/1165883003/diff/1/tools/telemetry/telemetry/v...
tools/telemetry/telemetry/value/failure.py:46: page_name = self.page.name
This seems right eventually, but would it mess up the dashboard's data?
What is the default value of page.name?

[eakuefner, 2015-06-05 15:03:57]

https://codereview.chromium.org/1165883003/diff/1/tools/telemetry/telemetry/v...
File tools/telemetry/telemetry/value/failure.py (right):

https://codereview.chromium.org/1165883003/diff/1/tools/telemetry/telemetry/v...
tools/telemetry/telemetry/value/failure.py:46: page_name = self.page.name
On 2015/06/05 at 14:58:08, nednguyen wrote:
> This seems right eventually, but would it mess up the dashboard's data?
> What is the default value of page.name?

No, this won't interfere with the dashboard since the chart JSON pipeline makes
no direct use of __repr__. Stringification is only used by tests and
serialization, and ChartJsonOutputFormatter uses additional machinery originally
introduced by BuildbotOutputFormatter to make sure that pages without names are
referred to by URL instead, in chart JSON in particular.

As it stands, this is fixing a stringification bug where Telemetry will crash if
it tries to serialize a non-Page Story, as in story_runner_unittest.

[nednguyen, 2015-06-05 15:45:48]

lgtm

[eakuefner, 2015-06-05 15:47:15]

The CQ bit was checked by eakuefner@chromium.org

[commit-bot: I haz the power, 2015-06-05 15:49:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1165883003/1

[commit-bot: I haz the power, 2015-06-05 16:52:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-06-05 16:53:19]

Patchset 1 (id:??) landed as
https://crrev.com/8507ca60f46cd2a05482d3f484d8dc6ba7cd403f
Cr-Commit-Position: refs/heads/master@{#333069}