Issue 1165863003: Fix fx_basic_memmgr_unittest.cpp under stricter GN rules

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1165863003: Fix fx_basic_memmgr_unittest.cpp under stricter GN rules (Closed)

Created:
5 years, 6 months ago by Tom Sepez

Modified:
5 years, 6 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix fx_basic_memmgr_unittest.cpp under stricter GN rules This caused a revert of the PDFium roll. TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/7bb4d8dc9e825f484e180205254aee1488cc34dc

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	core/src/fxcrt/fx_basic_memmgr_unittest.cpp	View	1	1 chunk	+6 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

Tom Sepez

Committed patchset #2 (id:20001) manually as 7bb4d8dc9e825f484e180205254aee1488cc34dc (presubmit successful).

5 years, 6 months ago (2015-06-03 19:05:38 UTC) #2

Lei Zhang

5 years, 6 months ago (2015-06-04 22:17:01 UTC) #3

Message was sent while issue was closed.

lgtm

Alternatively, borrow ignore_result() from Chromium's base/