Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: components/scheduler/renderer/renderer_scheduler_impl_unittest.cc

Issue 1165853002: Pipe impl_latency_takes_priority_ to the RenderScheduler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Made the flag default Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/scheduler/renderer/renderer_scheduler_impl_unittest.cc
diff --git a/components/scheduler/renderer/renderer_scheduler_impl_unittest.cc b/components/scheduler/renderer/renderer_scheduler_impl_unittest.cc
index 9a6cb38d668df57ce96719abad6bca062267f8df..44b0b4bebdc8594f3416bce811354fdb717cfe07 100644
--- a/components/scheduler/renderer/renderer_scheduler_impl_unittest.cc
+++ b/components/scheduler/renderer/renderer_scheduler_impl_unittest.cc
@@ -214,6 +214,10 @@ class RendererSchedulerImplTest : public testing::Test {
Policy CurrentPolicy() { return scheduler_->current_policy_; }
+ bool BeginMainFrameOnCriticalPath() {
+ return scheduler_->begin_main_frame_on_critical_path_;
+ }
+
// Helper for posting several tasks of specific types. |task_descriptor| is a
// string with space delimited task identifiers. The first letter of each
// task identifier specifies the task type:
@@ -1642,4 +1646,18 @@ TEST_F(RendererSchedulerImplTest, MismatchedDidHandleInputEventOnMainThread) {
FakeInputEvent(blink::WebInputEvent::GestureFlingStart));
}
+TEST_F(RendererSchedulerImplTest, BeginMainFrameOnCriticalPath) {
+ ASSERT_FALSE(BeginMainFrameOnCriticalPath());
+
+ scheduler_->WillBeginFrame(cc::BeginFrameArgs::Create(
+ BEGINFRAME_FROM_HERE, clock_->Now(), base::TimeTicks(),
+ base::TimeDelta::FromMilliseconds(1000), cc::BeginFrameArgs::NORMAL));
+ ASSERT_TRUE(BeginMainFrameOnCriticalPath());
+
+ scheduler_->WillBeginFrame(cc::BeginFrameArgs::Create(
brianderson 2015/06/09 01:12:42 Do you need to add another argument to Create?
Sami 2015/06/09 09:47:34 We did that in the first patch set but I was think
brianderson 2015/06/10 01:13:35 Ah ok. This is good then.
+ BEGINFRAME_FROM_HERE, clock_->Now(), base::TimeTicks(),
+ base::TimeDelta::FromMilliseconds(1000), cc::BeginFrameArgs::NORMAL));
+ ASSERT_FALSE(BeginMainFrameOnCriticalPath());
+}
+
} // namespace scheduler
« cc/scheduler/scheduler.cc ('K') | « components/scheduler/renderer/renderer_scheduler_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698