Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3154)

Unified Diff: cc/scheduler/scheduler_unittest.cc

Issue 1165853002: Pipe impl_latency_takes_priority_ to the RenderScheduler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/scheduler/scheduler_unittest.cc
diff --git a/cc/scheduler/scheduler_unittest.cc b/cc/scheduler/scheduler_unittest.cc
index 3fc5c062dac2c871096d08609064883b14892e76..ad47b5924596b3adbb43873e08555a5814f11ee2 100644
--- a/cc/scheduler/scheduler_unittest.cc
+++ b/cc/scheduler/scheduler_unittest.cc
@@ -3003,5 +3003,38 @@ TEST_F(SchedulerTest, AuthoritativeVSyncInterval) {
EXPECT_EQ(authoritative_interval, scheduler_->BeginImplFrameInterval());
}
+TEST_F(SchedulerTest, MainThreadOnCriticalPath) {
+ SetUpScheduler(true);
+ scheduler_->SetImplLatencyTakesPriority(true);
+ EXPECT_FALSE(scheduler_->MainThreadOnCriticalPath());
+
+ scheduler_->SetImplLatencyTakesPriority(false);
+ EXPECT_TRUE(scheduler_->MainThreadOnCriticalPath());
+}
+
+TEST_F(SchedulerTest, BeginFrameArgs_OnCriticalPath) {
+ scheduler_settings_.use_external_begin_frame_source = true;
+ SetUpScheduler(true);
+
+ scheduler_->SetImplLatencyTakesPriority(false);
+ scheduler_->SetChildrenNeedBeginFrames(true);
+
+ EXPECT_SCOPED(AdvanceFrame());
+ EXPECT_TRUE(client_->begin_frame_is_sent_to_children());
+ EXPECT_TRUE(client_->begin_frame_args_sent_to_children().on_critical_path);
+}
+
+TEST_F(SchedulerTest, BeginFrameArgs_NotOnCriticalPath) {
+ scheduler_settings_.use_external_begin_frame_source = true;
+ SetUpScheduler(true);
+
+ scheduler_->SetImplLatencyTakesPriority(true);
+ scheduler_->SetChildrenNeedBeginFrames(true);
+
+ EXPECT_SCOPED(AdvanceFrame());
+ EXPECT_TRUE(client_->begin_frame_is_sent_to_children());
+ EXPECT_FALSE(client_->begin_frame_args_sent_to_children().on_critical_path);
+}
+
} // namespace
} // namespace cc

Powered by Google App Engine
This is Rietveld 408576698