Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 1165833002: Refactoring: Move StyledMarkupSerializer::m_reversedPrecedingMarkup to StyledMarkupAccumulator (Closed)

Created:
4 years, 11 months ago by hajimehoshi
Modified:
4 years, 11 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-style_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Refactoring: Move StyledMarkupSerializer::m_reversedPrecedingMarkup to StyledMarkupAccumulator This CL moves StyledMarkupSerializer::m_reversedPrecedingMarkup to StyledMarkupAccumulator because 1. StyleMarkupSerializer is a template class but the functions I moved don't use the template parameter, so moving them to a non-template class will improve code health. 2. We can make some functions in StyledMarkupAccumulator private. We have no plan to use these methods externally so far and this is also good for code health. BUG=n/a TEST=n/a; no behavior change Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196399

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -71 lines) Patch
M Source/core/editing/StyledMarkupAccumulator.h View 1 2 3 chunks +14 lines, -9 lines 0 comments Download
M Source/core/editing/StyledMarkupAccumulator.cpp View 1 2 2 chunks +32 lines, -2 lines 0 comments Download
M Source/core/editing/StyledMarkupSerializer.h View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/core/editing/StyledMarkupSerializer.cpp View 1 2 6 chunks +6 lines, -51 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
hajimehoshi
PTAL
4 years, 11 months ago (2015-06-03 06:49:56 UTC) #2
yosin_UTC9
lgtm
4 years, 11 months ago (2015-06-03 07:19:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165833002/20001
4 years, 11 months ago (2015-06-03 07:20:48 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/64968)
4 years, 11 months ago (2015-06-03 11:00:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165833002/40001
4 years, 11 months ago (2015-06-03 11:17:42 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2015-06-03 13:43:13 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196399

Powered by Google App Engine
This is Rietveld 408576698