Source/core/css/CSSSelector.cpp - Issue 1165823005: Remove an outdated TODO about selector parsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSSelector.cpp

Issue 1165823005: Remove an outdated TODO about selector parsing (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/CSSSelector.cpp

diff --git a/Source/core/css/CSSSelector.cpp b/Source/core/css/CSSSelector.cpp

index 901343b96cec615c663eb461dc23f542a204d604..71d196b2f9e26e5e1be59f346f33e64cbf30ce58 100644

--- a/Source/core/css/CSSSelector.cpp

+++ b/Source/core/css/CSSSelector.cpp

@@ -272,8 +272,6 @@ PseudoId CSSSelector::pseudoId(PseudoType type)

return NOPSEUDO;

}

-// TODO(timloh): Unify with CSSSelectorParser, which also compares pseudo names as strings

// Could be made smaller and faster by replacing pointer with an

// offset into a string buffer and making the bit fields smaller but

// that could not be maintained by hand.

« no previous file with comments | « no previous file | no next file » | no next file with comments »