Issue 1165823005: Remove an outdated TODO about selector parsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1165823005: Remove an outdated TODO about selector parsing (Closed)

Created:
4 years, 11 months ago by Timothy Loh

Modified:
4 years, 11 months ago

Reviewers:
dstockwell, esprehn, rune

CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove an outdated TODO about selector parsing This patch removes an TODO about selector parsing which is no longer relevant as the CSSSelectorParser now compares PseudoType enum values instead of strings. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196575

Patch Set 1 #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	Source/core/css/CSSSelector.cpp	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165823005/1

4 years, 11 months ago (2015-06-05 14:34:21 UTC) #6

commit-bot: I haz the power

4 years, 11 months ago (2015-06-05 14:38:11 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196575

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages