Extract the element implementation logic to function mods in <webview>.

extensions/renderer/resources/guest_view/guest_view.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This module implements a wrapper for a guestview that manages its
 // creation, attaching, and destruction.
 
 var CreateEvent = require('guestViewEvents').CreateEvent;
 var EventBindings = require('event_bindings');
 var GuestViewInternal =
     require('binding').Binding.create('guestViewInternal').generate();
 var GuestViewInternalNatives = requireNative('guest_view_internal');
 
 // Events.
 var ResizeEvent = CreateEvent('guestViewInternal.onResize');
 
-// Possible states.
-var GUEST_STATE_ATTACHED = 2;
-var GUEST_STATE_CREATED = 1;
-var GUEST_STATE_START = 0;
-
 // Error messages.
 var ERROR_MSG_ALREADY_ATTACHED = 'The guest has already been attached.';
 var ERROR_MSG_ALREADY_CREATED = 'The guest has already been created.';
 var ERROR_MSG_INVALID_STATE = 'The guest is in an invalid state.';
 var ERROR_MSG_NOT_ATTACHED = 'The guest is not attached.';
 var ERROR_MSG_NOT_CREATED = 'The guest has not been created.';
 
 // Properties.
 var PROPERTY_ON_RESIZE = 'onresize';
 
 // Contains and hides the internal implementation details of |GuestView|,
 // including maintaining its state and enforcing the proper usage of its API
 // fucntions.
 function GuestViewImpl(guestView, viewType, guestInstanceId) {
   if (guestInstanceId) {
     this.id = guestInstanceId;
-    this.state = GUEST_STATE_CREATED;
+    this.state = GuestViewImpl.GuestState.GUEST_STATE_CREATED;
   } else {
     this.id = 0;
-    this.state = GUEST_STATE_START;
+    this.state = GuestViewImpl.GuestState.GUEST_STATE_START;
   }
   this.actionQueue = [];
   this.contentWindow = null;
   this.guestView = guestView;
   this.pendingAction = null;
   this.viewType = viewType;
   this.internalInstanceId = 0;
 
   this.setupOnResize();
 }
 
+// Possible states.
+GuestViewImpl.GuestState = {
+  GUEST_STATE_START: 0,
+  GUEST_STATE_CREATED: 1,
+  GUEST_STATE_ATTACHED: 2
+};
+
 // Sets up the onResize property on the GuestView.
 GuestViewImpl.prototype.setupOnResize = function() {
   $Object.defineProperty(this.guestView, PROPERTY_ON_RESIZE, {
     get: function() {
       return this[PROPERTY_ON_RESIZE];
     }.bind(this),
     set: function(value) {
       this[PROPERTY_ON_RESIZE] = value;
     }.bind(this),
     enumerable: true
@@ skipping 75 matching lines @@
     var view = GuestViewInternalNatives.GetViewFromID(viewInstanceId);
     if (view && view.guest) {
       return $Function.apply(func,
                              privates(view.guest).internal,
                              $Array.slice(arguments));
     }
   };
 };
 
 // Internal implementation of attach().
-GuestViewImpl.prototype.attachImpl = function(
+GuestViewImpl.prototype.attachImpl$ = function(
     internalInstanceId, viewInstanceId, attachParams, callback) {
   // Check the current state.
   if (!this.checkState('attach')) {
     this.handleCallback(callback);
     return;
   }
 
   // Callback wrapper function to store the contentWindow from the attachGuest()
   // callback, handle potential attaching failure, register an automatic detach,
   // and advance the queue.
   var callbackWrapper = function(callback, contentWindow) {
     // Check if attaching failed.
     if (!contentWindow) {
-      this.state = GUEST_STATE_CREATED;
+      this.state = GuestViewImpl.GuestState.GUEST_STATE_CREATED;
       this.internalInstanceId = 0;
     } else {
       // Only update the contentWindow if attaching is successful.
       this.contentWindow = contentWindow;
     }
 
     this.handleCallback(callback);
   };
 
   attachParams['instanceId'] = viewInstanceId;
   GuestViewInternalNatives.AttachGuest(internalInstanceId,
                                        this.id,
                                        attachParams,
                                        callbackWrapper.bind(this, callback));
 
   this.internalInstanceId = internalInstanceId;
-  this.state = GUEST_STATE_ATTACHED;
+  this.state = GuestViewImpl.GuestState.GUEST_STATE_ATTACHED;
 
   // Detach automatically when the container is destroyed.
   GuestViewInternalNatives.RegisterDestructionCallback(
       internalInstanceId, this.weakWrapper(function() {
-    if (this.state != GUEST_STATE_ATTACHED ||
+    if (this.state != GuestViewImpl.GuestState.GUEST_STATE_ATTACHED ||
         this.internalInstanceId != internalInstanceId) {
       return;
     }
 
     this.internalInstanceId = 0;
-    this.state = GUEST_STATE_CREATED;
+    this.state = GuestViewImpl.GuestState.GUEST_STATE_CREATED;
   }, viewInstanceId));
 };
 
 // Internal implementation of create().
-GuestViewImpl.prototype.createImpl = function(createParams, callback) {
+GuestViewImpl.prototype.createImpl$ = function(createParams, callback) {
   // Check the current state.
   if (!this.checkState('create')) {
     this.handleCallback(callback);
     return;
   }
 
   // Callback wrapper function to store the guestInstanceId from the
   // createGuest() callback, handle potential creation failure, and advance the
   // queue.
   var callbackWrapper = function(callback, guestInfo) {
     this.id = guestInfo.id;
     this.contentWindow =
         GuestViewInternalNatives.GetContentWindow(guestInfo.contentWindowId);
 
     // Check if creation failed.
     if (this.id === 0) {
-      this.state = GUEST_STATE_START;
+      this.state = GuestViewImpl.GuestState.GUEST_STATE_START;
       this.contentWindow = null;
     }
 
     ResizeEvent.addListener(this.callOnResize, {instanceId: this.id});
     this.handleCallback(callback);
   };
 
-  GuestViewInternal.createGuest(this.viewType,
-                                createParams,
-                                callbackWrapper.bind(this, callback));
+  this.sendCreateRequest(createParams, callbackWrapper.bind(this, callback));
 
-  this.state = GUEST_STATE_CREATED;
+  this.state = GuestViewImpl.GuestState.GUEST_STATE_CREATED;
+};
+
+GuestViewImpl.prototype.sendCreateRequest = function(
+    createParams, boundCallback) {
+  GuestViewInternal.createGuest(this.viewType, createParams, boundCallback);
 };
 
 // Internal implementation of destroy().
 GuestViewImpl.prototype.destroyImpl = function(callback) {
   // Check the current state.
   if (!this.checkState('destroy')) {
     this.handleCallback(callback);
     return;
   }
 
-  if (this.state == GUEST_STATE_START) {
+  if (this.state == GuestViewImpl.GuestState.GUEST_STATE_START) {
     // destroy() does nothing in this case.
     this.handleCallback(callback);
     return;
   }
 
   // If this guest is attached, then detach it first.
   if (!!this.internalInstanceId) {
     GuestViewInternalNatives.DetachGuest(this.internalInstanceId);
   }
 
   GuestViewInternal.destroyGuest(this.id,
                                  this.handleCallback.bind(this, callback));
 
   // Reset the state of the destroyed guest;
   this.contentWindow = null;
   this.id = 0;
   this.internalInstanceId = 0;
-  this.state = GUEST_STATE_START;
+  this.state = GuestViewImpl.GuestState.GUEST_STATE_START;
   if (ResizeEvent.hasListener(this.callOnResize)) {
     ResizeEvent.removeListener(this.callOnResize);
   }
 };
 
 // Internal implementation of detach().
 GuestViewImpl.prototype.detachImpl = function(callback) {
   // Check the current state.
   if (!this.checkState('detach')) {
     this.handleCallback(callback);
     return;
   }
 
   GuestViewInternalNatives.DetachGuest(
       this.internalInstanceId,
       this.handleCallback.bind(this, callback));
 
   this.internalInstanceId = 0;
-  this.state = GUEST_STATE_CREATED;
+  this.state = GuestViewImpl.GuestState.GUEST_STATE_CREATED;
 };
 
 // Internal implementation of setSize().
 GuestViewImpl.prototype.setSizeImpl = function(sizeParams, callback) {
   // Check the current state.
   if (!this.checkState('setSize')) {
     this.handleCallback(callback);
     return;
   }
 
   GuestViewInternal.setSize(this.id, sizeParams,
                             this.handleCallback.bind(this, callback));
 };
 
 // The exposed interface to a guestview. Exposes in its API the functions
 // attach(), create(), destroy(), and getId(). All other implementation details
 // are hidden.
 function GuestView(viewType, guestInstanceId) {
   privates(this).internal = new GuestViewImpl(this, viewType, guestInstanceId);
 }
 
 // Attaches the guestview to the container with ID |internalInstanceId|.
 GuestView.prototype.attach = function(
     internalInstanceId, viewInstanceId, attachParams, callback) {
   var internal = privates(this).internal;
-  internal.actionQueue.push(internal.attachImpl.bind(
+  internal.actionQueue.push(internal.attachImpl$.bind(
       internal, internalInstanceId, viewInstanceId, attachParams, callback));
   internal.performNextAction();
 };
 
 // Creates the guestview.
 GuestView.prototype.create = function(createParams, callback) {
   var internal = privates(this).internal;
-  internal.actionQueue.push(internal.createImpl.bind(
+  internal.actionQueue.push(internal.createImpl$.bind(
       internal, createParams, callback));
   internal.performNextAction();
 };
 
 // Destroys the guestview. Nothing can be done with the guestview after it has
 // been destroyed.
 GuestView.prototype.destroy = function(callback) {
   var internal = privates(this).internal;
   internal.actionQueue.push(internal.destroyImpl.bind(internal, callback));
   internal.performNextAction();
@@ skipping 22 matching lines @@
 };
 
 // Returns the ID for this guestview.
 GuestView.prototype.getId = function() {
   var internal = privates(this).internal;
   return internal.id;
 };
 
 // Exports
 exports.GuestView = GuestView;
+exports.GuestViewImpl = GuestViewImpl;
+exports.ResizeEvent = ResizeEvent;