Extract the element implementation logic to function mods in <webview>.

extensions/renderer/resources/guest_view/guest_view_container.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This module implements the shared functionality for different guestview
 // containers, such as web_view, app_view, etc.
 
 var DocumentNatives = requireNative('document_natives');
 var GuestView = require('guestView').GuestView;
 var GuestViewInternalNatives = requireNative('guest_view_internal');
 var IdGenerator = requireNative('id_generator');
 
 function GuestViewContainer(element, viewType) {
   privates(element).internal = this;
   this.attributes = {};
   this.element = element;
   this.elementAttached = false;
   this.viewInstanceId = IdGenerator.GetNextId();
   this.viewType = viewType;
 
   this.setupGuestProperty();
   this.guest = new GuestView(viewType);
   this.setupAttributes();
 
-  privates(this).browserPluginElement = this.createBrowserPluginElement();
+  privates(this).internalElement = this.createInternalElement$();
   this.setupFocusPropagation();
   var shadowRoot = this.element.createShadowRoot();
-  shadowRoot.appendChild(privates(this).browserPluginElement);
+  shadowRoot.appendChild(privates(this).internalElement);
 
   GuestViewInternalNatives.RegisterView(this.viewInstanceId, this);
 }
 
 // Forward public API methods from |proto| to their internal implementations.
 GuestViewContainer.forwardApiMethods = function(proto, apiMethods) {
   var createProtoHandler = function(m) {
     return function(var_args) {
       var internal = privates(this).internal;
       return $Function.apply(internal[m], internal, arguments);
@@ skipping 38 matching lines @@
         contentResizeEvent.oldHeight = e.oldHeight;
         contentResizeEvent.newWidth = e.newWidth;
         contentResizeEvent.newHeight = e.newHeight;
         this.dispatchEvent(contentResizeEvent);
       }.bind(this);
     }.bind(this),
     enumerable: true
   });
 };
 
-GuestViewContainer.prototype.createBrowserPluginElement = function() {
+GuestViewContainer.prototype.createInternalElement$ = function() {
   // We create BrowserPlugin as a custom element in order to observe changes
   // to attributes synchronously.
   var browserPluginElement =
       new GuestViewContainer[this.viewType + 'BrowserPlugin']();
   privates(browserPluginElement).internal = this;
   return browserPluginElement;
 };
 
 GuestViewContainer.prototype.setupFocusPropagation = function() {
   if (!this.element.hasAttribute('tabIndex')) {
     // GuestViewContainer needs a tabIndex in order to be focusable.
     // TODO(fsamuel): It would be nice to avoid exposing a tabIndex attribute
     // to allow GuestViewContainer to be focusable.
     // See http://crbug.com/231664.
     this.element.setAttribute('tabIndex', -1);
   }
   this.element.addEventListener('focus', this.weakWrapper(function(e) {
     // Focus the BrowserPlugin when the GuestViewContainer takes focus.
-    privates(this).browserPluginElement.focus();
+    privates(this).internalElement.focus();
   }));
   this.element.addEventListener('blur', this.weakWrapper(function(e) {
     // Blur the BrowserPlugin when the GuestViewContainer loses focus.
-    privates(this).browserPluginElement.blur();
+    privates(this).internalElement.blur();
   }));
 };
 
-GuestViewContainer.prototype.attachWindow = function() {
+GuestViewContainer.prototype.attachWindow$ = function() {
   if (!this.internalInstanceId) {
     return true;
   }
 
   this.guest.attach(this.internalInstanceId,
                     this.viewInstanceId,
                     this.buildParams());
   return true;
 };
 
+GuestViewContainer.prototype.onInternalInstanceID = function(

[Fady Samuel, 2015/06/09 03:16:31]

onInternalInstanceId

[lazyboy, 2015/06/09 18:48:22]

Done.

+    internalInstanceId) {
+  this.internalInstanceId = internalInstanceId;
+
+  // Track when the element resizes using the element resize callback.
+  GuestViewInternalNatives.RegisterElementResizeCallback(
+      this.internalInstanceId, this.weakWrapper(this.onElementResize));
+
+  if (!this.guest.getId()) {
+    return;
+  }
+  this.guest.attach(this.internalInstanceId,
+                    this.viewInstanceId,
+                    this.buildParams());
+};
+
 GuestViewContainer.prototype.handleBrowserPluginAttributeMutation =

[Fady Samuel, 2015/06/09 03:16:31]

nit: handleInternalElementAttributeMutation.

Change all references to browserPlugin to instead say internalElement.

[lazyboy, 2015/06/09 18:48:22]

Done mostly except one local variable, where it helps to know that we are
creating a browser plugin <object>. This is the inside the default
createInternalElement$

     function(name, oldValue, newValue) {
   if (name == 'internalinstanceid' && !oldValue && !!newValue) {
-    privates(this).browserPluginElement.removeAttribute('internalinstanceid');
-    this.internalInstanceId = parseInt(newValue);
-
-    // Track when the element resizes using the element resize callback.
-    GuestViewInternalNatives.RegisterElementResizeCallback(
-        this.internalInstanceId, this.weakWrapper(this.onElementResize));
-
-    if (!this.guest.getId()) {
-      return;
-    }
-    this.guest.attach(this.internalInstanceId,
-                      this.viewInstanceId,
-                      this.buildParams());
+    privates(this).internalElement.removeAttribute('internalinstanceid');
+    this.onInternalInstanceID(parseInt(newValue));
   }
 };
 
 GuestViewContainer.prototype.onElementResize = function(newWidth, newHeight) {
   if (!this.guest.getId())
     return;
   this.guest.setSize({normal: {width: newWidth, height: newHeight}});
 };
 
 GuestViewContainer.prototype.buildParams = function() {
@@ skipping 123 matching lines @@
   // Delete the callbacks so developers cannot call them and produce unexpected
   // behavior.
   delete proto.createdCallback;
   delete proto.attachedCallback;
   delete proto.detachedCallback;
   delete proto.attributeChangedCallback;
 }
 
 // Exports.
 exports.GuestViewContainer = GuestViewContainer;