PartitionAlloc: improve how statistics appear in chrome://tracing.

PartitionAlloc: improve how statistics appear in chrome://tracing.

- Remove "waste", it's a useless number.
- Report "slot size" as a dedicated value so it can be sorted on.
- Temporarily force good column ordering by using numeric perfixes to leverage
the current alphabetical sort for column ordering.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196706

[Chris Evans, 2015-06-05 22:24:57]

cevans@chromium.org changed reviewers:
+ primiano@chromium.org, ssid@chromium.org

[Chris Evans, 2015-06-05 23:22:16]

On 2015/06/05 22:25:03, Chris Evans wrote:

(resolved merge conflicts)

[haraken, 2015-06-06 14:47:38]

LGTM

[Primiano Tucci (use gerrit), 2015-06-06 16:00:37]

https://codereview.chromium.org/1165703010/diff/20001/Source/platform/Partiti...
File Source/platform/PartitionAllocMemoryDumpProvider.cpp (right):

https://codereview.chromium.org/1165703010/diff/20001/Source/platform/Partiti...
Source/platform/PartitionAllocMemoryDumpProvider.cpp:45:
allocatorDump->AddScalar("0slot_size", "bytes", memoryStats->bucketSlotSize);
Hmmm I see that you want to enforce ordering and unfortunately today we don't
have a way to express it, but this IMHO looks too much of a hack.
How about we do the hack in the UI (say: sort by (column.name contains "size",
column.name) until we have a better way to express ordering here? (so this would
work also for the upcoming oilpan dumper)

[Primiano Tucci (use gerrit), 2015-06-06 16:01:35]

Ah, and % the numbered prefixes the rest LGTM

[Chris Evans, 2015-06-08 22:23:12]

On 2015/06/06 16:01:35, Primiano Tucci wrote:
> Ah, and % the numbered prefixes the rest LGTM

Thanks. Landing without the numbered prefixes.

I think a good UI ordering would be the order in which the AddScalar calls are
currently made. Maybe one way to tackle this is to preserve the ordering all the
way up to the UI.

[Chris Evans, 2015-06-08 22:23:16]

The CQ bit was checked by cevans@chromium.org

[Chris Evans, 2015-06-08 22:23:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
primiano@chromium.org, haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1165703010/#ps40001
(title: "Remove numeric prefix hacks.")

[commit-bot: I haz the power, 2015-06-08 22:23:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1165703010/40001

[commit-bot: I haz the power, 2015-06-08 23:23:15]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196706