Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1165703009: Rebaseline onunload handler tests (Closed)

Created:
5 years, 6 months ago by kouhei (in TOK)
Modified:
5 years, 6 months ago
Reviewers:
tkent
CC:
blink-reviews, shans, rjwright, tzik, mlamouri+watch-blink_chromium.org, blink-reviews-animation_chromium.org, nhiroki, mvanouwerkerk+watch_chromium.org, timvolodine, darktears, kinuko+fileapi, Eric Willigers
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Rebaseline onunload handler tests BUG=496247, 277124 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196556

Patch Set 1 #

Patch Set 2 : remove passing web platform tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -246 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -84 lines 0 comments Download
M LayoutTests/battery-status/detached-no-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Geolocation/callback-to-deleted-context-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Geolocation/disconnected-frame-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Geolocation/disconnected-frame-permission-denied-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Geolocation/notimer-after-unload-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/Location/set-location-after-close-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/window-closed-immediate-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/defaultView-on-detached-document-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/events/onunload-clears-onbeforeunload-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/events/onunload-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/events/onunload-not-on-body-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/events/onunload-postmessage-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/events/pageshow-pagehide-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/events/pageshow-pagehide-on-back-uncached-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/events/stop-load-in-unload-handler-using-document-write-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/events/touch/touch-handler-iframe-unload-assert-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/files/file-reader-detached-no-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/forms/button-state-restore-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/state-restore-skip-stateless-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/frames/frame-unload-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/frames/layout-after-destruction-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/history/history-length-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/history/history-replace-updates-current-item-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/history/location-replace-hash-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/history/saves-state-after-fragment-nav-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/loader/child-frame-add-after-back-forward-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/loader/frame-location-change-not-added-to-history-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/loader/frame-src-change-not-added-to-history-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/loader/onunload-form-submit-crash-2-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/loader/onunload-form-submit-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/loader/page-dismissal-modal-dialogs-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/loader/ping-error-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/loader/scroll-position-restored-on-back-at-load-event-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/loader/scroll-position-restored-on-reload-at-load-event-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/loader/start-load-in-unload-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/loader/stateobjects/document-destroyed-navigate-back-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/loader/stateobjects/pushstate-clears-forward-history-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/loader/stateobjects/pushstate-in-iframe-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/loader/stateobjects/replacestate-in-iframe-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/loader/unload-form-about-blank-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/loader/unload-form-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/loader/unload-form-post-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/loader/unload-hyperlink-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/loader/unload-hyperlink-targeted-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/loader/unload-javascript-url-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/loader/unload-reload-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/loader/unload-window-location-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/speech/scripted/speechrecognition-detached-no-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/xmlhttprequest/xmlhttprequest-detached-mixedcontent-no-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/gamepad/gamepad-detached-no-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/navigation/beacon-detached-no-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/navigation/history-back-across-form-submission-to-fragment-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/navigation/image-load-in-subframe-unload-handler-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/navigation/image-load-in-unload-handler-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/navigation/redirect-on-back-updates-history-item-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/navigation/redirect-on-reload-updates-history-item-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/notifications/close-on-document-unload-expected.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
M LayoutTests/http/tests/notifications/request-permission-detached-context-expected.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
M LayoutTests/http/tests/security/window-events-pass-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/test_navigation_type_backforward-expected.txt View 1 1 chunk +0 lines, -13 lines 0 comments Download
M LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_attributes_order-expected.txt View 1 1 chunk +0 lines, -46 lines 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/frame-load-cancelled-abort-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/frame-unload-abort-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/xhr-onunload-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-unload-sync-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/transitions/interrupted-accelerated-transition-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/vibration/vibration-detached-no-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webaudio/offlineaudiocontext-detached-no-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webaudio/scriptprocessornode-detached-no-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
kouhei (in TOK)
5 years, 6 months ago (2015-06-05 02:19:18 UTC) #2
kouhei (in TOK)
Am I allowed to NOTRY these changes?
5 years, 6 months ago (2015-06-05 02:19:36 UTC) #3
tkent
lgtm On 2015/06/05 02:19:36, kouhei wrote: > Am I allowed to NOTRY these changes? I ...
5 years, 6 months ago (2015-06-05 02:30:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165703009/1
5 years, 6 months ago (2015-06-05 04:01:34 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/34664)
5 years, 6 months ago (2015-06-05 04:08:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165703009/20001
5 years, 6 months ago (2015-06-05 04:47:22 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 05:51:01 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196556

Powered by Google App Engine
This is Rietveld 408576698