Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/core/events/MouseEvent.idl

Issue 1165693005: Change MouseEvent.button to be 'short' instead of 'unsigned short' (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updating as per review comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/events/MouseEvent.cpp ('K') | « Source/core/events/MouseEvent.cpp ('k') | Source/core/events/MouseEventInit.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/events/MouseEvent.idl
diff --git a/Source/core/events/MouseEvent.idl b/Source/core/events/MouseEvent.idl
index 9a420321ec149aac821f9d89d893c40d6e26e57e..d35894274032b9a561d200965e344cd81147c6c1 100644
--- a/Source/core/events/MouseEvent.idl
+++ b/Source/core/events/MouseEvent.idl
@@ -31,8 +31,7 @@
readonly attribute boolean shiftKey;
readonly attribute boolean altKey;
readonly attribute boolean metaKey;
- // TODO(philipj): button should be short, not unsigned short.
- readonly attribute unsigned short button;
+ readonly attribute short button;
readonly attribute unsigned short buttons;
readonly attribute EventTarget? relatedTarget;
// TODO(philipj): boolean getModifierState(DOMString keyArg);
« Source/core/events/MouseEvent.cpp ('K') | « Source/core/events/MouseEvent.cpp ('k') | Source/core/events/MouseEventInit.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698