LayoutTests/fast/events/constructors/wheel-event-constructor.html - Issue 1165693005: Change MouseEvent.button to be 'short' instead of 'unsigned short'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/events/constructors/wheel-event-constructor.html

Issue 1165693005: Change MouseEvent.button to be 'short' instead of 'unsigned short' (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updating as per review comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/events/constructors/mouse-event-constructor.html ('K') | « LayoutTests/fast/events/constructors/mouse-event-constructor-expected.txt ('k') | LayoutTests/fast/events/constructors/wheel-event-constructor-expected.txt » ('j') | Source/core/events/MouseEvent.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/events/constructors/wheel-event-constructor.html

diff --git a/LayoutTests/fast/events/constructors/wheel-event-constructor.html b/LayoutTests/fast/events/constructors/wheel-event-constructor.html

index 03a92936bfa99ecfa1920c21e6a02ba0c1b1c8ca..06e1c4024bddbf071217c63c4dea4696308877a1 100644

--- a/LayoutTests/fast/events/constructors/wheel-event-constructor.html

+++ b/LayoutTests/fast/events/constructors/wheel-event-constructor.html

@@ -170,17 +170,16 @@ shouldBe("new WheelEvent('eventType', { deltaMode: {valueOf: function () { retur

});

// button is passed.

-// Numbers within the unsigned short range.

+// Numbers within the short range.

shouldBe("new WheelEvent('eventType', { button: 0 }).button", "0");

shouldBe("new WheelEvent('eventType', { button: 1 }).button", "1");

-shouldBe("new WheelEvent('eventType', { button: 65534 }).button", "65534");

philipj_slow 2015/06/10 08:46:25 Ditto.

ramya.v 2015/06/10 09:21:28 Done.

-// Numbers that are equal to ((unsigned short)-1) should be treated as 0.

+// Numbers that are equal to -1 should be treated as 0.

shouldBe("new WheelEvent('eventType', { button: 65535 }).button", "0");

shouldBe("new WheelEvent('eventType', { button: 9007199254740991 }).button", "0");

shouldBe("new WheelEvent('eventType', { button: -1 }).button", "0");

-// Numbers out of the unsigned short range.

+// Numbers out of the short range.

// 2^{64}-1

shouldBe("new WheelEvent('eventType', { button: 18446744073709551615 }).button", "0");

shouldBe("new WheelEvent('eventType', { button: 12345678901234567890 }).button", "2048");