Source/core/events/MouseEvent.idl - Issue 1165693005: Change MouseEvent.button to be 'short' instead of 'unsigned short'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/events/MouseEvent.idl

Issue 1165693005: Change MouseEvent.button to be 'short' instead of 'unsigned short' (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updating test cases Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/events/MouseEvent.idl

diff --git a/Source/core/events/MouseEvent.idl b/Source/core/events/MouseEvent.idl

index 9a420321ec149aac821f9d89d893c40d6e26e57e..7a7969fbb518ce74299f65f862bf1018fcf5b278 100644

--- a/Source/core/events/MouseEvent.idl

+++ b/Source/core/events/MouseEvent.idl

@@ -31,8 +31,7 @@

readonly attribute boolean shiftKey;

readonly attribute boolean altKey;

readonly attribute boolean metaKey;

- // TODO(philipj): button should be short, not unsigned short.

- readonly attribute unsigned short button;

+ readonly attribute short button;

philipj_slow 2015/06/09 09:35:38 Please add some whitespace so that all the names l

ramya.v 2015/06/09 11:14:31 Done.

readonly attribute unsigned short buttons;

readonly attribute EventTarget? relatedTarget;

// TODO(philipj): boolean getModifierState(DOMString keyArg);

« Source/core/events/MouseEvent.cpp ('K') | « Source/core/events/MouseEvent.cpp ('k') | Source/core/events/MouseEventInit.idl » ('j') | no next file with comments »