Source/core/events/MouseEventInit.idl - Issue 1165693005: Change MouseEvent.button to be 'short' instead of 'unsigned short'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/events/MouseEventInit.idl

Issue 1165693005: Change MouseEvent.button to be 'short' instead of 'unsigned short' (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/events/MouseEventInit.idl

diff --git a/Source/core/events/MouseEventInit.idl b/Source/core/events/MouseEventInit.idl

index 6a4fe24d328780feddfed520820a99f36f4461dc..cbb4d7d83781cf975b530f6450f09681fc714900 100644

--- a/Source/core/events/MouseEventInit.idl

+++ b/Source/core/events/MouseEventInit.idl

@@ -9,8 +9,7 @@ dictionary MouseEventInit : EventModifierInit {

long screenY = 0;

long clientX = 0;

long clientY = 0;

- // TODO(philipj): button should be short, not unsigned short.

- unsigned short button = 0;

+ short button = 0;

unsigned short buttons = 0;

EventTarget? relatedTarget = null;

« no previous file with comments | « Source/core/events/MouseEvent.idl ('k') | no next file » | no next file with comments »